Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nrf-ble-driver:*-windows ci] Miscellaneous failures? #12450

Closed
strega-nil opened this issue Jul 16, 2020 · 3 comments · Fixed by #12455
Closed

[nrf-ble-driver:*-windows ci] Miscellaneous failures? #12450

strega-nil opened this issue Jul 16, 2020 · 3 comments · Fixed by #12455
Assignees
@JackBoosY
Labels
category:port-bug The issue is with a library, which is something the port should already support

Comments

@strega-nil
Copy link
Contributor

We should figure out what's going on with nrf-ble-driver, it's failing a bunch of PR tests: #12444, #12434, #12421, and a bunch of others.
@ras0219-msft
Copy link
Contributor

Looks like libmicrohttpd is installing include/platform.h -- very bad practice, sad faces

ras0219 pushed a commit to ras0219/vcpkg that referenced this issue Jul 16, 2020
@ras0219-msft
[libmicrohttpd] Add platform.h to restricted header list.
6385e9b 
Fixes microsoft#12450
@ras0219 ras0219 mentioned this issue Jul 16, 2020
Merged
@PhoebeHui
Copy link
Contributor

Related to #12445

@JackBoosY JackBoosY added the category:port-bug The issue is with a library, which is something the port should already support label Jul 17, 2020
ras0219-msft added a commit that referenced this issue Jul 21, 2020
@ras0219 @ras0219-msft
[libmicrohttpd] Add platform.h to restricted header list. (#12455)
44a5a4f 
Fixes #12450

Co-authored-by: Robert Schumacher <[email protected]>
hellozee pushed a commit to hellozee/vcpkg that referenced this issue Sep 11, 2020
@ras0219 @ras0219-msft @hellozee
[libmicrohttpd] Add platform.h to restricted header list. (microsof…
2fe39cd 
…t#12455)

Fixes microsoft#12450

Co-authored-by: Robert Schumacher <[email protected]>
strega-nil pushed a commit to strega-nil/vcpkg that referenced this issue May 5, 2021
@ras0219 @ras0219-msft
[libmicrohttpd] Add platform.h to restricted header list. (microsof…
1e34898 
…t#12455)

Fixes microsoft#12450

Co-authored-by: Robert Schumacher <[email protected]>
@Karlson2k
Copy link
Contributor

Looks like libmicrohttpd is installing include/platform.h -- very bad practice, sad faces

Note to keep in history.
libmicrohttpd does not install any header except libmicrohttpd.h.
vcpkg's portfile was designed incorrectly.

Current vcpkg version finally installs correct libmicrohttpd headers (after merging my PR #31740).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JackBoosY JackBoosY

Labels
category:port-bug The issue is with a library, which is something the port should already support
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[libmicrohttpd] Add platform.h to restricted header list. ras0219/vcpkg
5 participants
@Karlson2k @strega-nil @ras0219-msft @PhoebeHui @JackBoosY