Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add readline or editline #1268

Closed
nurse opened this issue Jun 12, 2017 · 9 comments
Closed

Add readline or editline #1268

nurse opened this issue Jun 12, 2017 · 9 comments
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR!

Comments

@nurse
Copy link

nurse commented Jun 12, 2017

Many command line tools depend its interactive editing on readline or libedit.
But such library is not ported to Visual C++ environment yet.
If either of readline or libedit is ported, it is helpful so much.

@bagong
Copy link
Contributor

bagong commented Jun 12, 2017

Anything that can more or less do as a drop-in replacement for readline would be lovely. Cutting down significantly on the more obscure readline features wouldn't matter ;) I'd be willing to contribute modestly to a bounty on this.

@codicodi
Copy link
Contributor

This one looks promising: http://mingweditline.sourceforge.net/

@nurse
Copy link
Author

nurse commented Jun 12, 2017

This one looks promising: http://mingweditline.sourceforge.net/

As far as I remember it doesn't work well on non ASCII environment because it uses ReadConsoleInput.

@bagong
Copy link
Contributor

bagong commented Jun 12, 2017

Here are two interesting projects, the later a header only lib:

https:/arangodb/linenoise-ng

https:/yhirose/cpp-linenoise

Linenoise is one of the most popular non-GPL readline replacements, but no 1:1 Windows port.

@nurse
Copy link
Author

nurse commented Jun 12, 2017

https:/yhirose/cpp-linenoise

It has some Unicode related code but as far as I understand ReadConsoleInput doesn't work well for some codepoints.

https:/arangodb/linenoise-ng

I didn't know linenoise's development is so advaned. It uses ReadConsoleInputW and maybe works well. I'll check it further later.

@ras0219-msft ras0219-msft added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Jun 12, 2017
@nurse
Copy link
Author

nurse commented Jun 13, 2017

I checked linenoise.
It looks good project if you want to make a tool which has readline functionality.
But it is not what I want, the drop-in replacement for readline.

@qmfrederik
Copy link
Contributor

#3504 tries to add readline, so if you're still looking for readline give that PR a try ;-)

@claudiofantacci
Copy link
Contributor

@nurse did you try readline from #3504?

Also:

I checked linenoise.

Do you mean linenoise-ng?

Thanks 😄

@nurse
Copy link
Author

nurse commented Sep 26, 2018

@qmfrederik @claudiofantacci I tried #3504 and it works fine, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR!
Projects
None yet
Development

No branches or pull requests

6 participants