Indirectly referenced library will always be installed with default features even if they're not required

[xuhongxu96]

Describe the bug
I have a libA referencing libB using manifest vcpkg.json:

{
    "$schema": "https://raw.githubusercontent.com/microsoft/vcpkg/master/scripts/vcpkg.schema.json",
    "name": "libA",
    "version": "0.1",
    "dependencies": ["libB"]
}

And libB references libzip[core]. libB's vcpkg.json (in my custom ports overlay) is:

{
    "$schema": "https://raw.githubusercontent.com/microsoft/vcpkg/master/scripts/vcpkg.schema.json",
    "name": "libB",
    "version": "0.1",
    "dependencies": [
        {
            "name": "libzip",
            "default-features": false
        }
    ]
}

When I use vcpkg install --feature-flags=manifests in libA's directory, it will install libzip with default features instead of [core].

For now, I have to workaround by changing my libA's vcpkg.json to:

{
    "$schema": "https://raw.githubusercontent.com/microsoft/vcpkg/master/scripts/vcpkg.schema.json",
    "name": "libA",
    "version": "0.1",
    "dependencies": [
        "libB",
        {
            "name": "libzip",
            "default-features": false
        }
    ]
}

Environment

• OS: All
• Compiler: Any

Expected behavior

If libzip is not installed already, it should be installed with the required features only.

[PhoebeHui]

We have discussed the similar behavior before, see PR #11602, this seems intentional behavior, @strega-nil, could you help confirm this issue?

[strega-nil]

Yeah, this is intentional. In the "classic mode" world, it makes sense to always install default features, so that we don't have to keep rebuilding libraries. In "manifest mode", it can make sense to not do that, since we don't have an install-set that is not described by manifests.

[JonLiu1993]

I'm closing this issue because all behaviors described in this thread are by design, please see the discussion in pr #11602 about the rationale.
liba:

{
    "$schema": "https://raw.githubusercontent.com/microsoft/vcpkg/master/scripts/vcpkg.schema.json",
    "name": "liba",
    "version": "0.1",
    "dependencies": ["sqlite3"]
}

libb:

{
    "$schema": "https://raw.githubusercontent.com/microsoft/vcpkg/master/scripts/vcpkg.schema.json",
    "name": "sqlite3",
    "version": "0.1",
    "dependencies": [
        {
            "name": "libzip",
            "default-features": false
        }
    ]
}

PS F:\Feature-test\test\vcpkg\libA\vcpkg> ./vcpkg install --feature-flags=manifests
Detecting compiler hash for triplet x64-windows...
A suitable version of powershell-core was not found (required v7.2.3). Downloading portable powershell-core v7.2.3...
Downloading powershell-core...
  https:/PowerShell/PowerShell/releases/download/v7.2.3/PowerShell-7.2.3-win-x86.zip -> F:\Feature-test\test\vcpkg\libA\vcpkg\downloads\PowerShell-7.2.3-win-x86.zip
Extracting powershell-core...
Detecting compiler hash for triplet x86-windows...
The following packages will be built and installed:
    sqlite3[core]:x86-windows -> 3.37.2#1
  * vcpkg-cmake[core]:x64-windows -> 2022-05-10#1
  * vcpkg-cmake-config[core]:x64-windows -> 2022-02-06#1

Changing liba's vcpkg.json to:

{
    "$schema": "https://raw.githubusercontent.com/microsoft/vcpkg/master/scripts/vcpkg.schema.json",
    "name": "liba",
    "version": "0.1",
    "dependencies": [
        "sqlite3",
        {
            "name": "libzip",
            "default-features": false
        }
    ]
}

PS F:\Feature-test\test\vcpkg\libA\vcpkg> ./vcpkg install --feature-flags=manifests
Detecting compiler hash for triplet x64-windows...
Detecting compiler hash for triplet x86-windows...
The following packages will be built and installed:
    libzip[core]:x86-windows -> 1.8.0
  * zlib[core]:x86-windows -> 1.2.12#1