Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libigl] Fix configure error and dependencies #10252

Merged
merged 6 commits into from
Aug 1, 2020
Merged

[libigl] Fix configure error and dependencies #10252

merged 6 commits into from
Aug 1, 2020

Conversation

JackBoosY
Copy link
Contributor

@JackBoosY JackBoosY commented Feb 28, 2020 •
edited
Loading

This PR will:

  • Fix configure error
  • Remove feature png due to source issue #1199
  • Remove feature python due to python binding are in the process of being redone.
  • Remove feature test
  • Feature imgui is enabled only during static builds
  • Since no symbol was exported, set it to only support static builds.

Fixes #8811 #12442

All features are tested pass in x86-windows, x64-windows and x64-windows-static.

@JackBoosY JackBoosY added wip info:internal This PR or Issue was filed by the vcpkg team. labels Feb 28, 2020
@JackBoosY JackBoosY mentioned this pull request Feb 28, 2020
Merged
@JackBoosY
Copy link
Contributor Author

/azp run

@kiyoakii
Copy link

kiyoakii commented Apr 14, 2020 •
edited
Loading

Thank you so much for your contribution! I couldn't find imgui feature in libigl using #include <igl/opengl/glfw/View.h> with libigl[core, opengl, glfw, imgui]:x64-windows installed before, so I merged this PR locally for a fast try. But upgrading vcpkg and auto-rebuilding didn't solve the problem.

You mentioned "Feature imgui is enabled only during static builds", but I still get BUILD_FAILED when installing static version.

$ .\vcpkg.exe install libigl[imgui]:x64-windows-static
Computing installation plan...
The following packages will be built and installed:
    libigl[core,imgui]:x64-windows-static
Starting package 1/1: libigl:x64-windows-static
Building package libigl[core,imgui]:x64-windows-static...
-- Using cached C:/Users/Jin Li/vcpkg/downloads/libigl-libigl-f6b406427400ed7ddb56cfc2577b6af571827c8c.tar.gz
-- Using source at C:/Users/Jin Li/vcpkg/buildtrees/libigl/src/f571827c8c-c8ef868db9
CMake Error at ports/libigl/portfile.cmake:39 (message):
  Feature imgui does not support static build currentlly
Call Stack (most recent call first):
  scripts/ports.cmake:90 (include)

@JackBoosY
Copy link
Contributor Author

@L-jin That's why this PR marked work in progress now.

@kiyoakii
Copy link

@JackBoosY Sorry, I thought this is all finished and waiting to be merged.

@JackBoosY JackBoosY mentioned this pull request Jun 19, 2020
Closed
@JackBoosY
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines failed to run 1 pipeline(s).

@JackBoosY JackBoosY added category:port-bug The issue is with a library, which is something the port should already support and removed requires:author-response labels Jun 19, 2020
@JackBoosY JackBoosY marked this pull request as ready for review June 23, 2020 07:52
@JackBoosY
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JackBoosY JackBoosY requested a review from PhoebeHui June 28, 2020 09:19
@JackBoosY
Copy link
Contributor Author

@L-jin Feature imgui only support dynamic build.

@PhoebeHui PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label Jun 29, 2020
@kiyoakii
Copy link

kiyoakii commented Jul 1, 2020

@JackBoosY Glad to know that. Thank you!

@JackBoosY
Copy link
Contributor Author

JackBoosY commented Jul 6, 2020 •
edited
Loading

The test item microsoft.vcpkg.pr (Run PR Test x64_osx) is deprecated.

@strega-nil
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

strega-nil
strega-nil suggested changes Jul 9, 2020
View reviewed changes
Copy link
Contributor

@strega-nil strega-nil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the port version should be rev'd back since there's a new version, right?

ports/libigl/CONTROL Outdated Show resolved Hide resolved
@JackBoosY @strega-nil
Update ports/libigl/CONTROL
602e4e1 
Co-authored-by: nicole mazzuca <[email protected]>
@JackBoosY
Copy link
Contributor Author

@strega-nil We can do it step by step.

@JackBoosY JackBoosY mentioned this pull request Jul 16, 2020
Closed
@JackBoosY JackBoosY linked an issue Jul 16, 2020 that may be closed by this pull request
[libigl] build failure with feature <imgui> #12442
Closed
@strega-nil
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@strega-nil
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@strega-nil strega-nil merged commit 75bb116 into microsoft:master Aug 1, 2020
@JackBoosY JackBoosY deleted the dev/jack/8811 branch August 3, 2020 02:25
hellozee pushed a commit to hellozee/vcpkg that referenced this pull request Sep 11, 2020
@JackBoosY @strega-nil @hellozee
[libigl] Fix configure error and dependencies (microsoft#10252)
13dcd3b 
* [libigl] Fix configure error and dependencies

* convert patch EOL

* [libigl] Update to 2.2.0

* Update ports/libigl/CONTROL

Co-authored-by: nicole mazzuca <[email protected]>

Co-authored-by: nicole mazzuca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strega-nil strega-nil strega-nil requested changes

@PhoebeHui PhoebeHui PhoebeHui approved these changes

Assignees

@PhoebeHui PhoebeHui

Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[libigl] build failure with feature <imgui> [libigl] build failure
4 participants
@JackBoosY @kiyoakii @strega-nil @PhoebeHui