[vcpkg] Fix issue #9781 by exporting from the installed directory #11015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ras0219-msft
requested review from
BillyONeal
and removed request for
ras0219-msft
BillyONeal
reviewed
Apr 27, 2020
BillyONeal
approved these changes
May 1, 2020
|
Thank you very much for creating this! Unfortunately there's an issue. For each triplet two folders are created instead of one, resulting in: Moving the subdirectory's content one level upper (root |
BillyONeal
reviewed
May 29, 2020
JackBoosY
approved these changes
Jun 11, 2020
JackBoosY
added
category:vcpkg-bug
JangBoo
pushed a commit
to JangBoo/vcpkg
that referenced
this pull request
Jun 18, 2020
…ctory (microsoft#11015) * [vcpkg] Fix issue microsoft#9781 by exporting from the installed directory * [vcpkg] Address code review comments for microsoft#11015 * [vcpkg] Remove duplicate triplet in installed path from exports Co-authored-by: Robert Schumacher <[email protected]>
strega-nil
pushed a commit
to strega-nil/vcpkg
that referenced
this pull request
May 5, 2021
…ctory (microsoft#11015) * [vcpkg] Fix issue microsoft#9781 by exporting from the installed directory * [vcpkg] Address code review comments for microsoft#11015 * [vcpkg] Remove duplicate triplet in installed path from exports Co-authored-by: Robert Schumacher <[email protected]>
kLiHz
added a commit
to kLiHz/vcpkg-build-opencv
that referenced
this pull request
Apr 17, 2023
As in issue microsoft/vcpkg#9781 and merged pull request microsoft/vcpkg#11015 , vcpkg doesn't use `packages` dir for either installing or exporting. Since now disabling binary cache, directory `installed` should be used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
vcpkg exportreads the files out of thepackages\directory for a given package. This is bothInstead, it should read the files from the installed directory (using the listfile as a manifest).
Fixes vcpkg export requires packages directory #9781 partially (for the core exporters)