-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rsocket] Add new port #11021
[rsocket] Add new port #11021
Conversation
scripts/ci.baseline.txt
Outdated
@@ -1587,6 +1587,8 @@ rpclib:x64-uwp=fail | |||
rpclib:x64-windows=ignore | |||
rpclib:x86-windows=ignore | |||
rpclib:x64-windows-static=ignore | |||
rsocket:x64-windows=fail |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this port does not support x64-windows
and x64-windows-static
, please add vcpkg_fail_port_install(ON_ARCH "x64")
to the top of portfile.cmake
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@curoky ,
folly itself according to it's port file supports x64 only (there is restriction in port file) and just mention instability on Windows in CONTROL file. Why not just rely on folly as dependency. If it's available then rsocket-cpp will work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@curoky , I cannot see explanation of the feature of the CONTROL file ( https://vcpkg.readthedocs.io/en/latest/maintainers/control-files/ )
but folly has
in folly itself I see following in CONTROL file
Supports: x64
In other port I see following (I assume this is some kind of restrictions) which can be usefull
Supports: (windows|linux)&x64
Supports: x86 | x64
Supports: !(windows|arm|uwp)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@curoky ,
according to folly readme windows is actually supported
folly supports gcc (5.1+), clang, or MSVC. It should run on Linux (x86-32, x86-64, and ARM), iOS, macOS, and Windows (x86-64).
I've found related issues
- [folly] build failure #9156 windows build worked some time ago
- [folly] update to latest #10045 seems at the moment there is some issue with visual studio
I suggest to not restrict platform for rsocket. Just require that folly exists.
Maybe I shouldn't add |
@@ -0,0 +1,26 @@ | |||
diff --git a/cmake/rsocket-config.cmake.in b/cmake/rsocket-config.cmake.in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@curoky , can you please explain the purpose of this patch? I've managed to build (at least) latest master under vcpkg without patching. Is there any issues with using lib in target project?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@curoky ,
I've got why this is needed. Maybe it worth to propose such patch to rsocket-cpp itself.
Thanks for your suggestions @malirod . |
@curoky ,
|
@malirod may need to add the following lines
Do you have a windows environment? Try it?
|
@curoky , Win x63 build issues
Additionally I found following things and propose to add them to this PR
3.Latest commit and sha
Would be great to get feedback about these items. I'll continue to try to make win build for a while. If you have any ideas how to fix issues please suggest. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this port doesn't support x64 triplets.
Please add the following codes to VCPKG_PATH/scripts/ci.baseline.txt:
rsocket:x64-windows=fail
rsocket:x64-windows-static=fail
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
When used with Visual Studio 2019, folly seems to have a bug. |
Waiting for #11370 merge and rerun pipeline test. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
When builiding rsocket with x64-windows:
|
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
* [rsocket] Add new port * [rsocket] don't build in some window environment * [rsocket] add missing deps in CONTROL * [rsocket] add missing deps in CONTROL * [rsocket] remove some deprecated args * [rsocket] romove vcpkg_fail_port_install(ON_ARCH x64) * [rsocket] only support x64 architecture * [rsocket] upgrade to 2020.05.04.00 * [rsocket] add vcpkg_fail_port_install to portfile * [rsocket] Fix find dependencies * Update ports/rsocket/portfile.cmake * Update ports/rsocket/CONTROL Co-authored-by: JackBoosY <[email protected]> Co-authored-by: Jack·Boos·Yu <[email protected]>
Describe the pull request
C++ implementation of RSocket http://rsocket.io
https:/rsocket/rsocket-cpp
What does your PR fix? Fixes #10705
N/A
Which triplets are supported/not supported? Have you updated the CI baseline?
Not support
x64-windows
x64-windows-static
Does your PR follow the maintainer guide?
Yes