-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ompl]: upgrade to 1.5.0 #11737
[ompl]: upgrade to 1.5.0 #11737
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please also bump the version in CONTROL
file?
Done! |
The feature But it build failed on x64-windows-static: Could you please try to look into this?
|
This seems to be an issue in the assimp library, not ompl itself. Are there other ports that successfully link against assume? |
Currently, there is only |
Sorry, I am too unfamiliar with windows dev to tackle this. I can comment out the |
Hi @mamoll |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
@mamoll |
Fixed. |
Please also test the feature and help confirm if it can work fine. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
I test the feature again based on both this PR and master branch. It failed with the same error as before on this PR. For master branch, it failed with anther reason. I will try to rebuild on the same machine with the latest master branch. I will update the results here after double checking this. |
Confirmed. This error is not related with the changes in this PR. In my opinion, it doesn't block this PR to be merged. Maybe we need to fix this later. LGTM now. |
Thanks for your contribution! |
Co-authored-by: NancyLi1013 <[email protected]>
Describe the pull request
upgrade OMPL port to latest version
Which triplets are supported/not supported? Have you updated the CI baseline?
Does your PR follow the maintainer guide?
yes