Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[openmesh] Upgrade to 8.1 #11739

Merged
merged 5 commits into from
Jul 13, 2020

Conversation

lijgame
Copy link
Contributor

@lijgame lijgame commented Jun 3, 2020

Tested on Window 10 with Visual Studio 2019 x64

Describe the pull request

  • What does your PR fix? #
    Upgrade openmesh to 8.1
  • Which triplets are supported/not supported? Have you updated the CI baseline?
    All triplets should be supported. CI baseline is not touched.
  • Does your PR follow the maintainer guide?
    Yes.

Tested on Window 10 with Visual Studio 2019 x64
@lijgame lijgame changed the title Upgrade openmesh to 8.1 [openmesh] Upgrade to 8.1 Jun 3, 2020
ports/openmesh/portfile.cmake Outdated Show resolved Hide resolved
ports/openmesh/portfile.cmake Outdated Show resolved Hide resolved
ports/openmesh/portfile.cmake Outdated Show resolved Hide resolved
@LilyWangL
Copy link
Contributor

Thanks for your PR! Can you please correct the Version field in the CONTROL file? You can get more information from maintainer-guide.md.

@LilyWangL LilyWangL added category:port-update The issue is with a library, which is requesting update new revision requires:author-response labels Jun 4, 2020
@lijgame
Copy link
Contributor Author

lijgame commented Jun 4, 2020

Thanks for your PR! Can you please correct the Version field in the CONTROL file? You can get more information from maintainer-guide.md.

Thanks for the suggestions.
New changes have been uploaded.

-Jack

@LilyWangL
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@LilyWangL
Copy link
Contributor

Now openmesh build failed on Linux with the following error:

There should be no empty directories in vcpkg/packages/openmesh_x64-linux
The following empty directories were found:

    vcpkg/packages/openmesh_x64-linux/share/OpenMesh

If a directory should be populated but is not, this might indicate an error in the portfile.
If the directories are not needed and their creation cannot be disabled, use something like this in the portfile to remove them:

    file(REMOVE_RECURSE "${CURRENT_PACKAGES_DIR}/a/dir" "${CURRENT_PACKAGES_DIR}/some/other/dir")

@LilyWangL
Copy link
Contributor

Pinging @lijgame for response. Is work still being done for this PR?

@lijgame
Copy link
Contributor Author

lijgame commented Jun 16, 2020

P

Overlooked the notification.
I will give it a try on Linux later tonight.

@lijgame
Copy link
Contributor Author

lijgame commented Jun 16, 2020

Some folders are installed into wrong path because Linux is case sensitive.
Now it should compile on Linux.
@LilyWangL

-Jiang

@LilyWangL LilyWangL added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Jun 17, 2020
@ras0219-msft ras0219-msft merged commit 63578d0 into microsoft:master Jul 13, 2020
@lijgame lijgame deleted the feature/upgrade_openmesh8.1 branch October 5, 2020 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants