[sfml][imgui-sfml] Push SFML_STATIC_LIBRARIES setting into sfml
#11800
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #10840 addresses the core problem of #9660, however it misplaces the truth of whether
sfml
was built statically. This PR causesSFMLConfig.cmake
to always override the definition ofSFML_STATIC_LIBRARIES
according to the original build configuration.As an additional drive-by fix, I've added a dependency on
opengl
to fix #10840 (comment).CC: @Neumann-A @JackBoosY @cenit
What does your PR fix?
Fixes residual issues with [imgui-sfml] Force imgui-sfml to be a static library #10840
Which triplets are supported/not supported? Have you updated the CI baseline?
No changes
Does your PR follow the maintainer guide?
Yes