Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cairo] Fix error in static build #11829

Merged
merged 11 commits into from
Jun 23, 2020

Conversation

NancyLi1013
Copy link
Contributor

Since glib only supports dynamic build, which blocks cairo to build static.
glib is an optional dependency for cairo.
Remove glib from the dependencies and add gobject as a feature for cairo.

Fix #11640.

Note: Feature gobject has passed with x86-windows and x64-windows.

@NancyLi1013 NancyLi1013 added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:internal This PR or Issue was filed by the vcpkg team. labels Jun 8, 2020
@NancyLi1013 NancyLi1013 marked this pull request as ready for review June 8, 2020 10:13
@NancyLi1013
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

ports/cairo/portfile.cmake Outdated Show resolved Hide resolved
@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Jun 17, 2020
@vicroms vicroms merged commit db74895 into microsoft:master Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cairo build failure, static library target
3 participants