Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[freetype] Update to 2.10.2 #11846

Merged
merged 4 commits into from
Jul 8, 2020
Merged

[freetype] Update to 2.10.2 #11846

merged 4 commits into from
Jul 8, 2020

Conversation

kevinlul
Copy link
Contributor

@kevinlul kevinlul commented Jun 9, 2020

https://sourceforge.net/projects/freetype/files/freetype2/2.10.2/

Which triplets are supported/not supported? Have you updated the CI baseline?

Need to verify that removing patch 5 actually works for dynamic triplets like x86-windows and x64-windows. In the FreeType CMake, we have

if (WIN32)
  target_compile_definitions(
    freetype PRIVATE _CRT_SECURE_NO_WARNINGS _CRT_NONSTDC_NO_WARNINGS)
  if (BUILD_SHARED_LIBS)
    target_compile_definitions(
      freetype PRIVATE DLL_EXPORT)
  endif ()
endif ()

so there shouldn't be a need to patch in a custom flag for this.

Does your PR follow the maintainer guide? Yes

@LilyWangL
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@LilyWangL LilyWangL added the category:port-update The issue is with a library, which is requesting update new revision label Jun 9, 2020
@LilyWangL LilyWangL added the info:reviewed Pull Request changes follow basic guidelines label Jun 11, 2020
@dan-shaw dan-shaw added requires:author-response and removed info:reviewed Pull Request changes follow basic guidelines labels Jun 11, 2020
@LilyWangL
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@LilyWangL
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@LilyWangL
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@LilyWangL
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kevinlul
Copy link
Contributor Author

Is there anything that I need to do? Maybe rebase onto current master? Though it looks like CI is failing on that too.

@LilyWangL
Copy link
Contributor

Waiting for #12067 merged, this PR will fix CI build error.

@LilyWangL
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@LilyWangL LilyWangL added the info:reviewed Pull Request changes follow basic guidelines label Jul 1, 2020
@ras0219-msft ras0219-msft merged commit 4e17c76 into microsoft:master Jul 8, 2020
@kevinlul kevinlul deleted the freetype-2.10.2 branch July 9, 2020 13:11
@kevinlul kevinlul mentioned this pull request Jul 11, 2020
Closed
@dalboris dalboris mentioned this pull request Aug 24, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ras0219-msft ras0219-msft ras0219-msft approved these changes

@LilyWangL LilyWangL LilyWangL approved these changes

@dan-shaw dan-shaw Awaiting requested review from dan-shaw

@BillyONeal BillyONeal Awaiting requested review from BillyONeal

Assignees

@LilyWangL LilyWangL

Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kevinlul @LilyWangL @BillyONeal @ras0219-msft @dan-shaw