-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[icu] Add tools #11897
[icu] Add tools #11897
Conversation
Tested this branch with VS2019 Community and Xerces-C++ master with
So the change looks fine as is. But if you need to have the tools optional as a [tools] component that would also work fine. |
@rleigh-codelibre |
If there are no any suggestions about this, I will add tools as current statues. |
I think this PR is fine as it is in terms of adding the tool support. Making it a separate component would be nice, but I'll have to have a dig into the vcpkg internals to see how to do it. Could that be done as a followup? |
Of course you can do that. In my opinion, we can consider to add it as a separate component in the future. Now what we need to do is to make sure that it can be used. |
My testing above with the CMake |
Currently, the executables generated in _vcpkg\buildtrees\icu\x64-windows-rel\bin are not provided in vcpkg.
Some ports require some of these executables to build with ICU support enabled.
So I add these to
tools/icu
directory.Fix #11782
Note: No feature needs to test.