Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[graphicsmagick] fix Magick++.h header location. #11926

Merged
merged 2 commits into from
Jun 18, 2020

Conversation

seanyen
Copy link
Contributor

@seanyen seanyen commented Jun 14, 2020

This pull request is to correct a header location for graphicsmagick. The issue was discovered when I enabled the Navigation 2 stack on Windows. The Magick++.h is expected to be placed one level up in the folder layout. Here is a example of the header layout in Ubuntu package: https://packages.ubuntu.com/bionic/amd64/libgraphicsmagick++1-dev/filelist.

@seanyen
Copy link
Contributor Author

seanyen commented Jun 14, 2020

This is ready for review and merge. Thanks!

@PhoebeHui
Copy link
Contributor

@seanyen, thanks for the PR!

Could you also update the version to '1.3.35-1' in CONTROL file?

@PhoebeHui PhoebeHui added category:port-bug The issue is with a library, which is something the port should already support requires:author-response labels Jun 15, 2020
@seanyen
Copy link
Contributor Author

seanyen commented Jun 15, 2020

@PhoebeHui Done!

Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your updates!

@PhoebeHui PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label Jun 18, 2020
@vicroms
Copy link
Member

vicroms commented Jun 18, 2020

Thanks for the PR!

@vicroms vicroms merged commit 791767a into microsoft:master Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants