[vcpkg] Put user-defined configuration triplets path on top of the search queue #11931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I believe that user-defined configuration triplets paths should be the first when searching for triplet configuration. This commit puts user-defined configuration triplets (if defined) on top of the search queue before standard paths. This could help to overwrite default tiplet configuration without setting custom triplet. P.S. If current implementation is better than my suggestion, feel free to ignore this commit. Signed-off-by: Vitalii Koshura <[email protected]>
AenBleidd
changed the title
LilyWangL
added
category:vcpkg-feature
dan-shaw
approved these changes
Jun 18, 2020
|
Thanks for the PR! This was actually a bug in vcpkg 😨 |
strega-nil
pushed a commit
to strega-nil/vcpkg
that referenced
this pull request
May 5, 2021
…ue (microsoft#11931) I believe that user-defined configuration triplets paths should be the first when searching for triplet configuration. This commit puts user-defined configuration triplets (if defined) on top of the search queue before standard paths. This could help to overwrite default tiplet configuration without setting custom triplet. P.S. If current implementation is better than my suggestion, feel free to ignore this commit. Signed-off-by: Vitalii Koshura <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe that user-defined configuration triplets paths should be the first when searching for triplet configuration.
This commit puts user-defined configuration triplets (if defined) on top of the search queue before standard paths.
This could help to overwrite default tiplet configuration without setting custom triplet.
P.S. If current implementation is better than my suggestion, feel free to ignore this commit.
Signed-off-by: Vitalii Koshura [email protected]