Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vcpkg baseline] Retrigger failed ports in baseline #11965

Merged
merged 4 commits into from
Jun 18, 2020

Conversation

PhoebeHui
Copy link
Contributor

Related to #7733 #11277 #11637

Retrigger failed ports, verified these ports locally, all passed.

@PhoebeHui PhoebeHui added the category:infrastructure Pertaining to the CI/Testing infrastrucutre label Jun 16, 2020
@PhoebeHui PhoebeHui added the info:internal This PR or Issue was filed by the vcpkg team. label Jun 16, 2020
@PhoebeHui
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@PhoebeHui
Copy link
Contributor Author

@BillyONeal, geographiclib:x64-windows-static failed to downlaod source, I checked the sourceforge, we could download the source successfully, but it's very slow, could you help take a look? these ports block CI testing with relate PRs.

-- Downloading https://sourceforge.net/projects/graphicsmagick/files/graphicsmagick/1.3.35/GraphicsMagick-1.3.35-windows-source.7z... Failed. Status: 7;"Couldn't connect to server"
CMake Error at scripts/cmake/vcpkg_download_distfile.cmake:175 (message):

  Failed to download file.
  If you use a proxy, please set the HTTPS_PROXY and HTTP_PROXY environment
  variables to "https://user:password@your-proxy-ip-address:port/".
  Otherwise, please submit an issue at https:/Microsoft/vcpkg/issues

@PhoebeHui PhoebeHui marked this pull request as ready for review June 17, 2020 09:56
@BillyONeal
Copy link
Member

I don't understand this change: the baseline (the CI build I mean) is currently green/passing.

We should not be forcing end users to rebuild stuff in vcpkg upgrade to fix transient issues in our own CI system.

@PhoebeHui
Copy link
Contributor Author

@BillyONeal, these ports failed in PR #7733 #11277 #11637 are our baseline issue, they are not related to the auther's changes, rerun the PR doesn't fix the issue, so I retriggered these ports.

@BillyONeal
Copy link
Member

@PhoebeHui If the problem is that a tombsone was created in those users' PR that invalidates results, the user can push an update to their PR that changes clean-tombstones-first and then change it back or rebase that change out:

delete-tombstones-first: false

For you folks who have access to the web interface I thought you were able to change that setting when queueing a build there, but I just tested and that doesn't seem to work :(

@BillyONeal
Copy link
Member

#12000 <-- I'm trying to fix the web interface thing over here

@PhoebeHui
Copy link
Contributor Author

Yes, remove tomestone doesn't work now, that why I summited this PR☺.

Currently, it doesn't work for geographiclib:x64-windows-static, it failed to download source even I retriggered it, that means it also fail when the author remove the tomestone, It might need to archive the source manually, since the server is very slow yesterday, hopes it's better today☺.

@BillyONeal
Copy link
Member

Right, if the problem is that the server giving us the sources is bad there's no guarantee that a rerun will help

@BillyONeal
Copy link
Member

Given the clean-every-CI change on tombstones I would prefer to limit this to geographiclib and polyclipping since those have meaningful changes.

@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Jun 18, 2020
@BillyONeal BillyONeal merged commit ba98abd into microsoft:master Jun 18, 2020
@PhoebeHui
Copy link
Contributor Author

@BillyONeal, thanks for your help!

JangBoo pushed a commit to JangBoo/vcpkg that referenced this pull request Jun 18, 2020
* [vcpkg baseline] Retrigger flaky ports

* update the url for geographiclib

* Rebase the changes

* Remove libpq:arm64-windows=fail in baseline file
JangBoo added a commit to JangBoo/vcpkg that referenced this pull request Jun 18, 2020
@PhoebeHui PhoebeHui deleted the dev/Phoebe/baseline branch July 14, 2020 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:infrastructure Pertaining to the CI/Testing infrastrucutre info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants