Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tinyxml2] Fix generation of pkg-config file #11966

Merged
merged 1 commit into from
Jun 18, 2020
Merged

[tinyxml2] Fix generation of pkg-config file #11966

merged 1 commit into from
Jun 18, 2020

Conversation

orudge
Copy link
Contributor

@orudge orudge commented Jun 16, 2020

This change should fix #10039.

@orudge orudge mentioned this pull request Jun 16, 2020
Closed
@NancyLi1013 NancyLi1013 self-assigned this Jun 17, 2020
NancyLi1013
NancyLi1013 reviewed Jun 17, 2020
View reviewed changes
Copy link
Contributor

@NancyLi1013 NancyLi1013 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please also bump the version in CONTROL file?

ports/tinyxml2/remove-d-suffix.patch Outdated Show resolved Hide resolved
@NancyLi1013 NancyLi1013 added category:port-bug The issue is with a library, which is something the port should already support requires:author-response labels Jun 17, 2020
@c72578
Copy link
Contributor

c72578 commented Jun 17, 2020

It should probably be the other way round:
Fix the generated tinyxml2.pc file and add the postfix there in case of a debug build.
Here is a suggestion for an upstream PR:
leethomason/tinyxml2#823

Patch file, tested under vcpkg:
https://patch-diff.githubusercontent.com/raw/leethomason/tinyxml2/pull/823.patch

@orudge
Copy link
Contributor Author

orudge commented Jun 17, 2020

Could you please also bump the version in CONTROL file?

Oops, missed that. Now done, thanks.

@NancyLi1013 NancyLi1013 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Jun 17, 2020
@vicroms
Copy link
Member

vicroms commented Jun 18, 2020

Thanks for the PR!

@vicroms vicroms merged commit 3c5c7d0 into microsoft:master Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NancyLi1013 NancyLi1013 NancyLi1013 approved these changes

Assignees

@NancyLi1013 NancyLi1013

Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tinyxml2 port ships malformed pkg-config .pc on x64-linux
4 participants
@orudge @c72578 @vicroms @NancyLi1013