Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[thrift] Update to 0.13.0 and fix OSX build #11981

Merged
merged 4 commits into from
Jun 17, 2020
Merged

[thrift] Update to 0.13.0 and fix OSX build #11981

merged 4 commits into from
Jun 17, 2020

Conversation

JackBoosY
Copy link
Contributor

@JackBoosY JackBoosY commented Jun 17, 2020 •
edited
Loading

thrift requires that the bison version is greater than 2.5.

  • add a message to notify the user
  • modify the bison search path in vcpkg on OSX to the bison path installed using brew

Fixes #7533

@JackBoosY JackBoosY added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:internal This PR or Issue was filed by the vcpkg team. category:port-update The issue is with a library, which is requesting update new revision depends:vm-update PR contains changes to the VM provisioning scripts labels Jun 17, 2020
@JackBoosY JackBoosY marked this pull request as ready for review June 17, 2020 07:19
@JackBoosY JackBoosY requested a review from PhoebeHui June 17, 2020 07:19
@PhoebeHui PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label Jun 17, 2020
@BillyONeal BillyONeal merged commit f18e0b4 into microsoft:master Jun 17, 2020
@JackBoosY JackBoosY deleted the dev/jack/7533 branch June 18, 2020 02:34
JangBoo pushed a commit to JangBoo/vcpkg that referenced this pull request Jun 18, 2020
@JackBoosY @JangBoo
[thrift] Update to 0.13.0 and fix OSX build (microsoft#11981)
89ae023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillyONeal BillyONeal BillyONeal approved these changes

@PhoebeHui PhoebeHui PhoebeHui approved these changes

Assignees

@BillyONeal BillyONeal

@PhoebeHui PhoebeHui

Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist category:port-update The issue is with a library, which is requesting update new revision depends:vm-update PR contains changes to the VM provisioning scripts info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[thrift:x64-osx] build failure
3 participants
@JackBoosY @BillyONeal @PhoebeHui