Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[plf-colony] Update to 5.33 #11993

Merged
merged 1 commit into from
Jun 17, 2020
Merged

[plf-colony] Update to 5.33 #11993

merged 1 commit into from
Jun 17, 2020

Conversation

Yen
Copy link
Contributor

@Yen Yen commented Jun 17, 2020

The previous version in the port file was specified as a date (2019-08-10), but the library itself uses a versioning scheme different to this.

If changing this port to use the versioning scheme of the library itself would break vcpkg versioning logic then this can be changed to continue the same date versioning scheme.

@ghost
Copy link

ghost commented Jun 17, 2020

CLA assistant check
All CLA requirements met.

@Yen Yen marked this pull request as ready for review June 17, 2020 18:30
@vicroms
Copy link
Member

vicroms commented Jun 17, 2020

Thanks for the PR!

This is a good change, we should use the versioning scheme that the libraries themselves use.

@vicroms vicroms merged commit 7bf7e81 into microsoft:master Jun 17, 2020
JangBoo pushed a commit to JangBoo/vcpkg that referenced this pull request Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants