Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[qhull] update version 8.0.0 #12015

Merged
merged 2 commits into from
Jun 18, 2020
Merged

[qhull] update version 8.0.0 #12015

merged 2 commits into from
Jun 18, 2020

Conversation

GiulioRomualdi
Copy link
Contributor

The PR updates the port qhull to the latest version 8.0.0

  • What does your PR fix? Fixes [qhull] update to 8.0.0 #12004

  • Which triplets are supported/not supported?

    • x64-windows
    • x64-windows-static
    • x64-osx
    • x64-linux
    • x64-uwp

The macOS patch is required because of qhull/qhull#65, while the uwp replicates the one already added in #7370.

I was already able to compile the port through GitHub Actions on Windows Linux and Mac. Please check here.

@ghost
Copy link

ghost commented Jun 18, 2020

CLA assistant check
All CLA requirements met.

* uwp.patch has been removed
* mac-fix.patch is updated. Now C++11 is required to compile the library
@vicroms
Copy link
Member

vicroms commented Jun 18, 2020

Thanks for the PR!

@vicroms vicroms merged commit a2cd3ad into microsoft:master Jun 18, 2020
@GiulioRomualdi GiulioRomualdi deleted the qhull/update_version_8.0.0 branch June 18, 2020 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[qhull] update to 8.0.0
2 participants