[vcpkg] Delete unused --purge-tombstones and introduce BufferedPrint class #12049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillyONeal
added
category:vcpkg-feature
ras0219-msft
approved these changes
Jun 22, 2020
| stdout_buffer.clear(); | ||
| } | ||
| } | ||
| ~buffered_print() { ::vcpkg::System::details::print(stdout_buffer); } |
There was a problem hiding this comment.
Side effects in destructors make me uncomfortable, but since this is a very targeted use case this is acceptable.
# Conflicts: # toolsrc/src/vcpkg/commands.ci.cpp
# Conflicts: # toolsrc/src/vcpkg/commands.ci.cpp
strega-nil
pushed a commit
to strega-nil/vcpkg
that referenced
this pull request
May 5, 2021
…class (microsoft#12049) * Introduce buffered_print class to manage buffered write patterns like in the ci command. * Remove --purge-tombstones option. * Law of demeter. * Make buffered_print imobile. * buffered_print => BufferedPrint * Fix merge conflict.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deletes this unused command line parameter and dedupes code that was doing buffer management while printing each package's hash. Hopefully this makes @ras0219 / @ras0219-msft 's life easier with binary caching implementation.