You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the OpenXR loader to the most recent released version, 1.0.11
Additionally, the loader was previously being built from a fork to include the openxr.hpp header. The hpp header is an official OpenXR Khronos project, but it's not currently integrated into the build of the OpenXR SDK itself. In order to work around this I previously used a fork where I manually included the header, but Vcpkg practices suggest it's preferable to make such modifications via patch or change to the portfile.
This this PR switches the port to use the official Khronos repository for the OpenXR SDK. Additionally at build time it also clones the required repositories to build the openxr.hpp file, and also includes a small patch file to correct a bug in the generated header.
The onus is therefore on the port maintainer to ensure that when they update the version of the OpenXR loader, they also update the refs of the additional repositories to match. The OpenXR-SDK-Source repo should have the same version tags as the main OpenXR-SDK repo, but the OpenXR-hpp repo doesn't use version tags and should just use the current HEAD. The port maintainer should also ensure that the patch file is updated as necessary or removed once the bug is fixed in the upstream repository.
Which triplets are supported/not supported? Have you updated the CI baseline?
ARM and UWP based triplets are not supported. This represents no change from the existing version.
My understanding was that the Vulkan port only checked for the presence of the Vulkan SDK. I've tested it with the x64-windows and x86- windows triplets, but not x64-windows-static.
Yes, your understanding is right. Thanks for your update.
Can it work on x64-window-static ? There is nothing need to be done for this PR if you can make sure that it can build with feature vulkan on these triplets.
@jherico
Could you please fix the issue on x64-linux?
The /lib/cmake folder should be merged with /debug/lib/cmake and moved to /share/openxr-loader/cmake.
Please use the helper function `vcpkg_fixup_cmake_targets()`
The following cmake files were found outside /share/openxr-loader. Please place cmake files in /share/openxr-loader.
/mnt/vcpkg-ci/packages/openxr-loader_x64-linux/lib/cmake/openxr/OpenXRConfigVersion.cmake
/mnt/vcpkg-ci/packages/openxr-loader_x64-linux/lib/cmake/openxr/OpenXRConfig.cmake
/mnt/vcpkg-ci/packages/openxr-loader_x64-linux/lib/cmake/openxr/OpenXRTargets.cmake
/mnt/vcpkg-ci/packages/openxr-loader_x64-linux/lib/cmake/openxr/OpenXRTargets-release.cmake
/mnt/vcpkg-ci/packages/openxr-loader_x64-linux/debug/lib/cmake/openxr/OpenXRConfigVersion.cmake
/mnt/vcpkg-ci/packages/openxr-loader_x64-linux/debug/lib/cmake/openxr/OpenXRConfig.cmake
/mnt/vcpkg-ci/packages/openxr-loader_x64-linux/debug/lib/cmake/openxr/OpenXRTargets.cmake
/mnt/vcpkg-ci/packages/openxr-loader_x64-linux/debug/lib/cmake/openxr/OpenXRTargets-debug.cmake
The /debug/lib/cmake folder should be merged with /lib/cmake into /share/openxr-loader
Found 3 error(s). Please correct the portfile:
/agent/_work/1/s/ports/openxr-loader/portfile.cmake
category:port-updateThe issue is with a library, which is requesting update new revisioninfo:reviewedPull Request changes follow basic guidelines
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NancyLi1013
added
the
category:port-update
strega-nil
added
requires:author-response
and removed
info:reviewed
Describe the pull request
Updates the OpenXR loader to the most recent released version, 1.0.11
Additionally, the loader was previously being built from a fork to include the
openxr.hppheader. The hpp header is an official OpenXR Khronos project, but it's not currently integrated into the build of the OpenXR SDK itself. In order to work around this I previously used a fork where I manually included the header, but Vcpkg practices suggest it's preferable to make such modifications via patch or change to the portfile.This this PR switches the port to use the official Khronos repository for the OpenXR SDK. Additionally at build time it also clones the required repositories to build the
openxr.hppfile, and also includes a small patch file to correct a bug in the generated header.The onus is therefore on the port maintainer to ensure that when they update the version of the OpenXR loader, they also update the refs of the additional repositories to match. The
OpenXR-SDK-Sourcerepo should have the same version tags as the mainOpenXR-SDKrepo, but theOpenXR-hpprepo doesn't use version tags and should just use the current HEAD. The port maintainer should also ensure that the patch file is updated as necessary or removed once the bug is fixed in the upstream repository.ARM and UWP based triplets are not supported. This represents no change from the existing version.
Yeah, I think