Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ffmpeg] Fix tools dependency dll file #12063

Merged
merged 3 commits into from
Jul 7, 2020
Merged

[ffmpeg] Fix tools dependency dll file #12063

merged 3 commits into from
Jul 7, 2020

Conversation

LilyWangL
Copy link
Contributor

Describe the pull request

@LilyWangL LilyWangL added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Jun 23, 2020
@LilyWangL LilyWangL requested a review from JackBoosY June 23, 2020 01:56
@LilyWangL
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@LilyWangL LilyWangL marked this pull request as ready for review June 23, 2020 06:45
@JackBoosY JackBoosY mentioned this pull request Jun 23, 2020
Merged
@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Jun 29, 2020
@ivanovmp
Copy link

ivanovmp commented Jul 3, 2020

So what is this PR waiting for? Why not merge it?

ras0219-msft
ras0219-msft requested changes Jul 6, 2020
View reviewed changes
ports/ffmpeg/portfile.cmake Outdated Show resolved Hide resolved
@JackBoosY JackBoosY removed the info:reviewed Pull Request changes follow basic guidelines label Jul 7, 2020
@ras0219-msft ras0219-msft merged commit 1658781 into microsoft:master Jul 7, 2020
@ras0219-msft
Copy link
Contributor

Thanks Lily!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JackBoosY JackBoosY JackBoosY approved these changes

@ras0219-msft ras0219-msft Awaiting requested review from ras0219-msft

Assignees

@JackBoosY JackBoosY

Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ffmpeg[ffmpeg]:x64-windows] compiles the executable but it won't open
4 participants
@LilyWangL @ivanovmp @ras0219-msft @JackBoosY