Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vcpkg baseline][paraview] Fix linux build #12144

Merged
merged 19 commits into from
Jun 30, 2020
Merged

[vcpkg baseline][paraview] Fix linux build #12144

merged 19 commits into from
Jun 30, 2020

Conversation

JackBoosY
Copy link
Contributor

@JackBoosY JackBoosY commented Jun 29, 2020 •
edited
Loading

  • Add feature tools
  • Add dependency embree3 to paraview on Linux.
  • Disable feature tools on OSX.

Other changes use @Neumann-A suggestion #11596 (comment).

Related: #12018 #12126 #11754 #12145 #12068 etc.

@JackBoosY JackBoosY added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. category:infrastructure Pertaining to the CI/Testing infrastrucutre labels Jun 29, 2020
This was referenced Jun 29, 2020
Merged
Merged
@JackBoosY JackBoosY changed the title [paraview] Fix linux build [vcpkg baseline][paraview] Fix linux build Jun 29, 2020
@JackBoosY JackBoosY marked this pull request as ready for review June 29, 2020 08:56
@JackBoosY JackBoosY requested a review from PhoebeHui June 29, 2020 08:57
JackBoosY
JackBoosY commented Jun 29, 2020
View reviewed changes
ports/paraview/portfile.cmake Outdated Show resolved Hide resolved
ports/paraview/portfile.cmake Outdated Show resolved Hide resolved
ports/paraview/portfile.cmake Outdated Show resolved Hide resolved
ports/paraview/portfile.cmake Outdated Show resolved Hide resolved
ports/paraview/portfile.cmake Outdated Show resolved Hide resolved
ports/paraview/portfile.cmake Outdated Show resolved Hide resolved
@JackBoosY
Copy link
Contributor Author

Modify by my iPhone, OMG.

@JackBoosY
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 12144 in repo microsoft/vcpkg

@JackBoosY
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Neumann-A
Copy link
Contributor

@JackBoosY: Updating vtk to 9.0.1 also solves the hdf5 issue. see #12149. The libmath issues still exists but it is probably not due to VTK but some other dependent library.

@Neumann-A Neumann-A mentioned this pull request Jun 29, 2020
Closed
@Neumann-A
Copy link
Contributor

@JackBoosY: [VCPKG-DEBUG]: Found libmath.a in embree3

@Neumann-A
Copy link
Contributor

Filled:
https://gitlab.kitware.com/paraview/paraview/-/issues/20043
PR can be closed since the temporary fix without patches is to add a build-depends on embree3

@BillyONeal
Copy link
Member

@Neumann-A Are you saying we should not merge this? I think it makes sense to merge it even if only to get the better hdf5 fix.

@BillyONeal BillyONeal merged commit 67ab613 into microsoft:master Jun 30, 2020
@JackBoosY JackBoosY deleted the dev/jack/fix_paraview_linux branch June 30, 2020 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillyONeal BillyONeal BillyONeal left review comments

@PhoebeHui PhoebeHui Awaiting requested review from PhoebeHui

Assignees

@PhoebeHui PhoebeHui

Labels
category:infrastructure Pertaining to the CI/Testing infrastrucutre category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JackBoosY @Neumann-A @BillyONeal @PhoebeHui