Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libexif] Update to 0.6.22 #12161

Merged
merged 3 commits into from
Jul 6, 2020

Conversation

oskaritimperi
Copy link
Contributor

Describe the pull request

  • What does your PR fix?

Update libexif version from 0.6.21 to 0.6.22

From the release page on github:

It largely contains stability, security and bugfixes.

Some EXIF 2.3 tags have been added.

It is ABI compatible to 0.6.21 release.

  • Which triplets are supported/not supported? Have you updated the CI baseline?

No change.

Yes.

From the release page on github:

> It largely contains stability, security and bugfixes.
>
> Some EXIF 2.3 tags have been added.
>
> It is ABI compatible to 0.6.21 release.
@ghost
Copy link

ghost commented Jun 30, 2020

CLA assistant check
All CLA requirements met.

Copy link
Contributor

@c72578 c72578 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In portfile.cmake:
include(vcpkg_common_functions) is deprecated.
Could you please remove this line.

Please change the following line:
file(INSTALL ${SOURCE_PATH}/COPYING DESTINATION ${CURRENT_PACKAGES_DIR}/share/libexif RENAME copyright)
->
file(INSTALL ${SOURCE_PATH}/COPYING DESTINATION ${CURRENT_PACKAGES_DIR}/share/${PORT} RENAME copyright)

- don't include vcpkg_commong_functions
- use the PORT variable when installing copyright file
@JackBoosY JackBoosY added the category:port-update The issue is with a library, which is requesting update new revision label Jul 1, 2020
ports/libexif/portfile.cmake Outdated Show resolved Hide resolved
@NancyLi1013
Copy link
Contributor

@oswjk
Is this PR ready to merge now?

@c72578
Thanks for your help to review. It's so nice.

@oskaritimperi oskaritimperi marked this pull request as ready for review July 1, 2020 06:51
@NancyLi1013 NancyLi1013 added the info:reviewed Pull Request changes follow basic guidelines label Jul 1, 2020
@ras0219-msft ras0219-msft merged commit d1a86d4 into microsoft:master Jul 6, 2020
@ras0219-msft
Copy link
Contributor

LGTM, thanks for the update!

@oskaritimperi oskaritimperi deleted the update-libexif-0622 branch August 3, 2020 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants