Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[opencc] Fix regression on pipeline #12246

Merged
merged 6 commits into from
Jul 6, 2020
Merged

[opencc] Fix regression on pipeline #12246

merged 6 commits into from
Jul 6, 2020

Conversation

JackBoosY
Copy link
Contributor

@JackBoosY JackBoosY commented Jul 3, 2020 •
edited
Loading

Add DISABLE_PARALLEL to vcpkg_install_cmake to avoid wrong build order.

@JackBoosY JackBoosY added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Jul 3, 2020
@koprok
Copy link
Contributor

koprok commented Jul 3, 2020

@JackBoosY , I think the error is caused by parallel build. Maybe adding DISABLE_PARALLEL option to vcpkg_install_cmake will fix it.

@JackBoosY
Copy link
Contributor Author

@koprok Good point! Thanks!

@JackBoosY JackBoosY requested a review from BillyONeal July 3, 2020 09:40
@JackBoosY JackBoosY marked this pull request as ready for review July 3, 2020 09:44
@koprok
Copy link
Contributor

koprok commented Jul 3, 2020

Hm... @JackBoosY , I think DISABLE_PARALLEL should be added to vcpkg_install_cmake, not to vcpkg_configure_cmake?

This was referenced Jul 3, 2020
Closed
Merged
@JackBoosY JackBoosY mentioned this pull request Jul 6, 2020
Merged
@LilyWangL LilyWangL added the info:reviewed Pull Request changes follow basic guidelines label Jul 6, 2020
@ras0219-msft ras0219-msft merged commit b6d4c4e into microsoft:master Jul 6, 2020
@JackBoosY JackBoosY deleted the dev/jack/fix_opencc_regression branch July 7, 2020 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ras0219 ras0219 ras0219 approved these changes

@BillyONeal BillyONeal BillyONeal approved these changes

Assignees

@PhoebeHui PhoebeHui

Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@JackBoosY @koprok @ras0219 @BillyONeal @ras0219-msft @PhoebeHui @LilyWangL