[vcpkg] Track hashes of cmake script helpers in consuming portfiles #12254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackBoosY
added
category:vcpkg-feature
|
ITK is #12298 |
2 tasks
|
The arm64 errors are all due to a failure while downloading winflexbison from sourceforge. |
|
@ras0219-msft I think |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
rpclib: qt5-imageformats: |
If you see that one just retry. I sometimes also see it locally but just retrying seems to be enough to make it build. Probably a parallel build issue? |
|
The osx failures: libb2: I didn't repro this issue locally, it built sucessfully. spaceland: source download failed, rerun the PR might work. |
|
Fix libb2 issue via PR #12398 |
strega-nil
approved these changes
Jul 13, 2020
| @@ -16,6 +16,7 @@ VCPKG_TARGET_IMPORT_LIBRARY_PREFIX import library prefix for target (same | |||
| VCPKG_TARGET_IMPORT_LIBRARY_SUFFIX import library suffix for target (same as CMAKE_IMPORT_LIBRARY_SUFFIX) | |||
| VCPKG_FIND_LIBRARY_PREFIXES target dependent prefixes used for find_library calls in portfiles | |||
| VCPKG_FIND_LIBRARY_SUFFIXES target dependent suffixes used for find_library calls in portfiles | |||
| VCPKG_SYSTEM_LIBRARIES list of libraries are provide by the toolchain and are not managed by vcpkg | |||
There was a problem hiding this comment.
Suggested change
| VCPKG_SYSTEM_LIBRARIES list of libraries are provide by the toolchain and are not managed by vcpkg | |
| VCPKG_SYSTEM_LIBRARIES list of libraries that are provided by the toolchain and are not managed by vcpkg |
|
Thanks everyone! |
Closed
strega-nil
pushed a commit
to strega-nil/vcpkg
that referenced
this pull request
May 5, 2021
…icrosoft#12254) * [vcpkg] Track hashes of cmake script helpers in consuming portfiles * [vcpkg] Format * [vcpkg_find_acquire_program] Use �cpkg_from_sourceforge for FLEX and BISON Co-authored-by: Robert Schumacher <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a heuristic method for determining what script helpers a given portfile is using and includes the hashes of those helpers into the port's package abi.