Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[eigen3] Fix eigen3 and cuda compatibility issue #12279

Merged
merged 4 commits into from
Jul 15, 2020
Merged

[eigen3] Fix eigen3 and cuda compatibility issue #12279

merged 4 commits into from
Jul 15, 2020

Conversation

JackBoosY
Copy link
Contributor

Fix issue when using eigen3:

f:\vcpkg\installed\x64-windows\include\eigen3\eigen\src/Core/arch/CUDA/Half.h(212): error: more than one instance of overloaded function "__hadd" matches the argument list:
            function "__hadd(int, int)"
            function "__hadd(__half, __half)"
            argument types are: (const Eigen::half, const Eigen::half)

Using the official patch: https://eigen.tuxfamily.org/bz/show_bug.cgi?id=1526

@JackBoosY JackBoosY added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Jul 6, 2020
@JackBoosY JackBoosY mentioned this pull request Jul 6, 2020
Merged
JackBoosY
JackBoosY commented Jul 6, 2020
View reviewed changes
ports/eigen3/portfile.cmake Outdated Show resolved Hide resolved
@JackBoosY JackBoosY marked this pull request as ready for review July 7, 2020 02:13
@NancyLi1013 NancyLi1013 added the info:reviewed Pull Request changes follow basic guidelines label Jul 7, 2020
JackBoosY
JackBoosY commented Jul 8, 2020
View reviewed changes
ports/eigen3/portfile.cmake Outdated Show resolved Hide resolved
@ras0219-msft ras0219-msft merged commit e59e5a4 into microsoft:master Jul 15, 2020
@JackBoosY JackBoosY deleted the dev/jack/fix_eigen_cuda branch July 16, 2020 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strega-nil strega-nil strega-nil approved these changes

@NancyLi1013 NancyLi1013 NancyLi1013 approved these changes

@ras0219-msft ras0219-msft Awaiting requested review from ras0219-msft

Assignees

@NancyLi1013 NancyLi1013

Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JackBoosY @strega-nil @ras0219-msft @NancyLi1013