Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hiredis] Fix feature ssl build error on windows #12354

Merged
merged 2 commits into from
Jul 15, 2020
Merged

[hiredis] Fix feature ssl build error on windows #12354

merged 2 commits into from
Jul 15, 2020

Conversation

NancyLi1013
Copy link
Contributor

@NancyLi1013 NancyLi1013 commented Jul 10, 2020 •
edited
Loading

Describe the pull request
pthread.h is not need on Windows platform.

Note: All feature have passed on following triplets:

  • x86-windows
  • x64-windows
  • x64-windows-static

@NancyLi1013 NancyLi1013 added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Jul 10, 2020
@NancyLi1013 NancyLi1013 marked this pull request as ready for review July 13, 2020 08:22
@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Jul 13, 2020
@NancyLi1013
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ras0219-msft ras0219-msft merged commit fc761eb into microsoft:master Jul 15, 2020
@ras0219-msft
Copy link
Contributor

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JackBoosY JackBoosY JackBoosY approved these changes

Assignees

@JackBoosY JackBoosY

Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[hiredis[ssl]] build failure
3 participants
@NancyLi1013 @ras0219-msft @JackBoosY