[vcpkg] Enable binary caching by default #12370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix passing multiple copies of single parameter arguments.
…ry cache path
strega-nil
added
the
depends:different-pr
|
Depends on #12351, afaict (or at least, that would make this PR much easier) |
… Ninja. Improve breadcrumbs for users encountering issues.
… tracking not looking in -err.log.
ras0219
force-pushed
the
dev/roschuma/binarycaching-default
branch
from
0f34152
to
353b6be
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ras0219-msft
removed
the
depends:different-pr
BillyONeal
reviewed
Jul 13, 2020
BillyONeal
approved these changes
Jul 13, 2020
Co-authored-by: Billy O'Neal <[email protected]>
|
🎉 |
strega-nil
pushed a commit
to strega-nil/vcpkg
that referenced
this pull request
May 5, 2021
* [vcpkg] Enable binary caching by default. Support `x-` migration. Fix passing multiple copies of single parameter arguments. * [vcpkg] Handle x- prefixes for general arguments * [vcpkg] Fix microsoft#12285 and improve documentation of default binary cache path * [vcpkg] Revert x- prefix homogenization for per-command arguments * [vcpkg] Only use accelerated compiler detection for Windows Desktop + Ninja. Improve breadcrumbs for users encountering issues. * [vcpkg] Fix compiler tracking not pre-downloading Ninja. Fix compiler tracking not looking in -err.log. * [vcpkg] Update toolsrc/src/vcpkg/binarycaching.cpp Co-authored-by: Billy O'Neal <[email protected]> * [vcpkg] Format Co-authored-by: Robert Schumacher <[email protected]> Co-authored-by: Billy O'Neal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vcpkg will now accept an
x-in front of any global (i.e. non-command-specific) command line parameters which are not already prefixed withx-. This has the effect that moving options from experimental to stabilized will not break existing users.This additionally fixes #12285 by using
%APPDATA%/../Localas a fallback for%LOCALAPPDATA%.Drive by fix: error when passing multiple copies of single parameter arguments.
+@alexkaratarakis /* It's happening! */