Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wxwidgets] Adding wxWidgets resource compiler (wxrc) to <triplet>/tools/wxwidgets directory #12485

Merged
merged 6 commits into from
Jul 31, 2020
Merged

[wxwidgets] Adding wxWidgets resource compiler (wxrc) to <triplet>/tools/wxwidgets directory #12485

merged 6 commits into from
Jul 31, 2020

Conversation

emersonfxbx
Copy link
Contributor

@emersonfxbx emersonfxbx commented Jul 18, 2020 •
edited
Loading

This pull request adds the resource compiler utility to the <triplet>/tools/wxwidgets directory.

@emersonfxbx emersonfxbx changed the title Adding wxWidgets resource compiler (wxrc) to <triplet>/tools/wxwidgets directory [wxwidgets] Adding wxWidgets resource compiler (wxrc) to <triplet>/tools/wxwidgets directory Jul 19, 2020
@PhoebeHui
Copy link
Contributor

@emersonfxbx, thanks for the PR! Could you also update the CONTROl version?

From
Version: 3.1.3-1

To
Version: 3.1.3
Port-Version: 2

@PhoebeHui PhoebeHui added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist requires:author-response labels Jul 20, 2020
@ghost
Copy link

ghost commented Jul 20, 2020 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

@PhoebeHui PhoebeHui added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Jul 21, 2020
PhoebeHui
PhoebeHui approved these changes Jul 21, 2020
View reviewed changes
Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your updates!

PhoebeHui
PhoebeHui reviewed Jul 22, 2020
View reviewed changes
ports/wxwidgets/portfile.cmake Outdated Show resolved Hide resolved
ports/wxwidgets/portfile.cmake Outdated Show resolved Hide resolved
@strega-nil
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@strega-nil strega-nil merged commit 544222f into microsoft:master Jul 31, 2020
hellozee pushed a commit to hellozee/vcpkg that referenced this pull request Sep 11, 2020
@emersonfxbx @PhoebeHui @hellozee
[wxwidgets] Adding wxWidgets resource compiler (wxrc) to <triplet>/to…
db86e5a 
…ols/wxwidgets directory (microsoft#12485)

* Adding wxWidgets resource compiler (wxrc) to <triplet>/tools/wxwidgets directory

* Fix tool missing dependencies

* CONTROL file version update

* Update ports/wxwidgets/portfile.cmake

* Update ports/wxwidgets/portfile.cmake

* Fix the build failures

Co-authored-by: Phoebe <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ras0219-msft ras0219-msft ras0219-msft left review comments

@PhoebeHui PhoebeHui PhoebeHui approved these changes

Assignees

@PhoebeHui PhoebeHui

Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@emersonfxbx @PhoebeHui @strega-nil @ras0219-msft