Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mpir] Fix build error if VCPKG_BUILD_TYPE is set as release or debug #12514

Merged
merged 4 commits into from
Jul 31, 2020
Merged

[mpir] Fix build error if VCPKG_BUILD_TYPE is set as release or debug #12514

merged 4 commits into from
Jul 31, 2020

Conversation

NancyLi1013
Copy link
Contributor

Adding VCPKG_BUILD_TYPE to judge the build type is release or debug.

Other changes:

  • Update CONTROL as vcpkg.json
  • Remove unneeded triplets

Note: No feature needs to test.

@NancyLi1013 NancyLi1013 added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Jul 21, 2020
@NancyLi1013 NancyLi1013 mentioned this pull request Jul 21, 2020
Closed
@NancyLi1013 NancyLi1013 marked this pull request as ready for review July 23, 2020 01:48
@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Jul 24, 2020
@strega-nil
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@strega-nil strega-nil merged commit 2cb2848 into microsoft:master Jul 31, 2020
@acgetchell acgetchell mentioned this pull request Jul 31, 2020
Closed
@acgetchell
Copy link

This commit breaks the port. #12671

strega-nil added a commit that referenced this pull request Jul 31, 2020
@strega-nil
Revert "[mpir] Fix build error if VCPKG_BUILD_TYPE is set as release …
d4a5d74 
…or debug (#12514)"

This reverts commit 2cb2848.
@strega-nil strega-nil mentioned this pull request Jul 31, 2020
Closed
hellozee pushed a commit to hellozee/vcpkg that referenced this pull request Sep 11, 2020
@NancyLi1013 @hellozee
[mpir] Fix build error if VCPKG_BUILD_TYPE is set as release or debug (…
5035257 
…microsoft#12514)

* [mpir] Fix build error if VCPKG_BUILD_TYPE is set as release or debug

* Update ci.baseline.txt

* EOL LF for vcpkg.json

* Update to use vcpkg_configure_make and vcpkg_install_make in UNIX
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JackBoosY JackBoosY JackBoosY approved these changes

Assignees

@JackBoosY JackBoosY

Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[mpir] build failure (regression)
4 participants
@NancyLi1013 @strega-nil @acgetchell @JackBoosY