Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nana] Fix the version and language standard #12543

Merged
merged 1 commit into from
Jul 31, 2020
Merged

[nana] Fix the version and language standard #12543

merged 1 commit into from
Jul 31, 2020

Conversation

PhoebeHui
Copy link
Contributor

Closes #5671

  1. Update the verison in CMakeLists.txt
  2. The original source https:/cnjinhao/nana/blob/master/CMakeLists.txt#L34 set language standard is cxx_std_17, so update it as well.

@PhoebeHui PhoebeHui added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Jul 23, 2020
@PhoebeHui PhoebeHui marked this pull request as ready for review July 24, 2020 01:54
@PhoebeHui PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label Jul 28, 2020
@strega-nil
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@strega-nil strega-nil merged commit 6afa4d3 into microsoft:master Jul 31, 2020
@PhoebeHui PhoebeHui deleted the dev/Phoebe/nana branch August 11, 2020 01:59
hellozee pushed a commit to hellozee/vcpkg that referenced this pull request Sep 11, 2020
@PhoebeHui @hellozee
[nana] Fix the version and language standard (microsoft#12543)
9075fd0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ras0219-msft ras0219-msft ras0219-msft approved these changes

@JackBoosY JackBoosY JackBoosY approved these changes

Assignees

@JackBoosY JackBoosY

Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[nana] ports/nana/CMakeLists.txt is outdated
4 participants
@PhoebeHui @strega-nil @ras0219-msft @JackBoosY