Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[grpc] Fix generate plugin grpc_csharp_ext #12611

Merged
merged 1 commit into from
Aug 7, 2020
Merged

[grpc] Fix generate plugin grpc_csharp_ext #12611

merged 1 commit into from
Aug 7, 2020

Conversation

JackBoosY
Copy link
Contributor

@JackBoosY JackBoosY commented Jul 28, 2020 •
edited
Loading

In grpc_csharp_ext.c line 31:

#ifdef GPR_WINDOWS
#define GPR_EXPORT __declspec(dllexport)
#define GPR_CALLTYPE __stdcall
#endif

#ifndef GPR_EXPORT
#define GPR_EXPORT
#endif

Since we set grpc to use the build as a static library, the plugin cannot be installed correctly.

Fixes #12579.

@JackBoosY JackBoosY added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Jul 28, 2020
@JackBoosY JackBoosY mentioned this pull request Jul 28, 2020
Closed
@JackBoosY JackBoosY marked this pull request as ready for review August 3, 2020 05:33
@PhoebeHui PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label Aug 5, 2020
@strega-nil strega-nil merged commit 95d3b86 into microsoft:master Aug 7, 2020
@JackBoosY JackBoosY deleted the dev/jack/12579 branch August 10, 2020 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhoebeHui PhoebeHui PhoebeHui approved these changes

Assignees

@PhoebeHui PhoebeHui

Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gRPC support for HoloLens2
3 participants
@JackBoosY @PhoebeHui @strega-nil