Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vcpkg baseline] Fix pbc build failure with x64-osx #12732

Merged
merged 6 commits into from
Aug 4, 2020
Merged

[vcpkg baseline] Fix pbc build failure with x64-osx #12732

merged 6 commits into from
Aug 4, 2020

Conversation

PhoebeHui
Copy link
Contributor

@PhoebeHui PhoebeHui commented Aug 4, 2020 •
edited
Loading

pbc requires gmp library on macos, add the dependency port.

Failures in CI pipeline:

checking for __gmpz_init in -lgmp... no
************************
gmp library not found
-e add its path to LDFLAGS
see ./configure --help
************************

Related PR #12727

@PhoebeHui PhoebeHui added the info:internal This PR or Issue was filed by the vcpkg team. label Aug 4, 2020
@PhoebeHui PhoebeHui self-assigned this Aug 4, 2020
@PhoebeHui PhoebeHui changed the title [pbc] test in ci [vcpkg baseline] fix pbc build failure with x64-osx Aug 4, 2020
@PhoebeHui PhoebeHui changed the title [vcpkg baseline] fix pbc build failure with x64-osx [vcpkg baseline] Fix pbc build failure with x64-osx Aug 4, 2020
PhoebeHui
PhoebeHui commented Aug 4, 2020
View reviewed changes
ports/pbc/CONTROL Outdated Show resolved Hide resolved
@PhoebeHui PhoebeHui added the category:port-bug The issue is with a library, which is something the port should already support label Aug 4, 2020
@JackBoosY
Copy link
Contributor

JackBoosY commented Aug 4, 2020 •
edited
Loading

Another solution (using vcpkg_*_make):
pbc.zip

@JackBoosY JackBoosY marked this pull request as ready for review August 4, 2020 08:54
@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Aug 4, 2020
This was referenced Aug 4, 2020
Merged
Merged
Merged
Merged
Merged
Merged
Closed
@PhoebeHui PhoebeHui mentioned this pull request Aug 4, 2020
Closed
@PhoebeHui
Copy link
Contributor Author

@strega-nil, could you help revirew and merge this PR firstly?

@Neumann-A
Copy link
Contributor

Another solution (using vcpkg_*_make):

was also wondering why it is not using vcpkg_configure_make etc.

@NancyLi1013 NancyLi1013 mentioned this pull request Aug 4, 2020
Merged
@strega-nil strega-nil merged commit 0e477d7 into microsoft:master Aug 4, 2020
@strega-nil
Copy link
Contributor

Thanks for fixing this phoebe :)

Jimmy-Hu added a commit to Jimmy-Hu/vcpkg that referenced this pull request Aug 5, 2020
@Jimmy-Hu
Merge pull request #271 from microsoft/master
534dc37 
[vcpkg baseline] Fix pbc build failure with x64-osx (microsoft#12732)
@PhoebeHui PhoebeHui deleted the dev/Phoebe/pbc branch August 11, 2020 01:59
hellozee pushed a commit to hellozee/vcpkg that referenced this pull request Sep 11, 2020
@PhoebeHui @hellozee
[vcpkg baseline] Fix pbc build failure with x64-osx (microsoft#12732)
10012e6 
* [pbc] test in ci

* Add depends port gmp

* Add dependency port gmp

* Update ports/pbc/CONTROL

* Build with make instead
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JackBoosY JackBoosY JackBoosY approved these changes

Assignees

@strega-nil strega-nil

@PhoebeHui PhoebeHui

@JackBoosY JackBoosY

Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PhoebeHui @JackBoosY @Neumann-A @strega-nil