[flac] Disable stack smash protection and FORTIFY_SOURCE for mingw #12761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ras0219
suggested changes
Aug 5, 2020
ports/libflac/portfile.cmake
Outdated
| -DBUILD_SHARED_LIBS=${BUILD_SHARED_LIBS} | ||
| -DWITH_STACK_PROTECTOR=${WITH_STACK_PROTECTOR} | ||
| -DCMAKE_C_FLAGS=${DISABLE_FORTIFYING} | ||
| -DCMAKE_CXX_FLAGS=${DISABLE_FORTIFYING}) |
There was a problem hiding this comment.
These shouldn't be passed like this, because it will compete with the flags being passed inside vcpkg_configure_cmake(); instead, we should append the flag to VCPKG_C(XX)_FLAGS:
string(APPEND VCPKG_C_FLAGS " ${DISABLE_FORTIFYING}")
vcpkg_configure_cmake( .... )There was a problem hiding this comment.
Alright I'll change it
NancyLi1013
reviewed
Aug 6, 2020
There was a problem hiding this comment.
Could you please update
file(COPY ${SOURCE_PATH}/COPYING.Xiph DESTINATION ${CURRENT_PACKAGES_DIR}/share/libflac)
file(RENAME ${CURRENT_PACKAGES_DIR}/share/libflac/COPYING.Xiph ${CURRENT_PACKAGES_DIR}/share/libflac/copyright)
as
file(INSTALL ${SOURCE_PATH}/COPYING.Xiph DESTINATION ${CURRENT_PACKAGES_DIR}/share/${PORT} RENAME copyright)?
NancyLi1013
added
category:port-feature
Done |
NancyLi1013
approved these changes
Aug 6, 2020
NancyLi1013
added
info:reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
This disables stack protection and FORTIFY_SOURCE on mingw, since it depends on libssp from GCC, which can cause licensing problems since libssp is GPL
All
mingwtripletsYes