Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[abseil] Fix CMake warning #12781

Merged
merged 2 commits into from
Aug 7, 2020
Merged

[abseil] Fix CMake warning #12781

merged 2 commits into from
Aug 7, 2020

Conversation

Dico200
Copy link
Contributor

@Dico200 Dico200 commented Aug 6, 2020

Describe the pull request

CMake Warning (dev) at C:/Users/Dico/AppData/Local/JetBrains/Toolbox/apps/CLion/ch-0/202.6397.106/bin/cmake/win/share/cmake-3.17/Modules/FindPackageHandleStandardArgs.cmake:272 (message):
  The package name passed to `find_package_handle_standard_args` (Threads)
  does not match the name of the calling package (absl).  This can lead to
  problems in calling code that expects `find_package` result variables
  (e.g., `_FOUND`) to follow a certain pattern.
Call Stack (most recent call first):
  C:/Users/Dico/AppData/Local/JetBrains/Toolbox/apps/CLion/ch-0/202.6397.106/bin/cmake/win/share/cmake-3.17/Modules/FindThreads.cmake:234 (FIND_PACKAGE_HANDLE_STANDARD_ARGS)
  C:/repos/vcpkg/installed/x64-windows-static-md/share/absl/abslConfig.cmake:3 (include)
  C:/repos/vcpkg/scripts/buildsystems/vcpkg.cmake:439 (_find_package)
  C:/repos/vcpkg/installed/x64-windows-static-md/share/gRPC/gRPCConfig.cmake:18 (find_package)
  C:/repos/vcpkg/scripts/buildsystems/vcpkg.cmake:437 (_find_package)
  CMakeLists.txt:27 (find_package)
This warning is for project developers.  Use -Wno-dev to suppress it.
  • Which triplets are supported/not supported? Have you updated the CI baseline?
    N/A

  • Does your PR follow the maintainer guide?
    I read through the guide, I think so, except that there is no CONTROL file in this port (I bumped the version in vcpkg.json)

@ghost
Copy link

ghost commented Aug 6, 2020

CLA assistant check
All CLA requirements met.

@Dico200 Dico200 changed the title Fix Abseil CMake warning [abseil] Fix CMake warning Aug 6, 2020
@Dico200
Copy link
Contributor Author

Dico200 commented Aug 6, 2020

I ran the command to format the manifest file - vcpkg x-format-manifest --all, it did not make any changes. I also did not change any formatting in the vcpkg.json file.

@NancyLi1013
Copy link
Contributor

Hi @Dico200
Thanks for this PR.

have you tested the feature cxx17?

@NancyLi1013 NancyLi1013 added category:port-bug The issue is with a library, which is something the port should already support requires:testing Needs tests added before merging labels Aug 7, 2020
@NancyLi1013
Copy link
Contributor

Feature cxx17 has passed with the following triplets:

  • x86-windows
  • x64-windows
  • x64-windows-static

@NancyLi1013 NancyLi1013 added info:reviewed Pull Request changes follow basic guidelines and removed requires:testing Needs tests added before merging labels Aug 7, 2020
@Dico200
Copy link
Contributor Author

Dico200 commented Aug 7, 2020

Hi @NancyLi1013 , it's a small effort :) thanks for the review!
I just tested the [cxx17] feature with success as well for x86-windows, x64-windows-static and even x64-windows-static-md.

@strega-nil strega-nil merged commit cfe88ab into microsoft:master Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants