-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[berkeleydb] Fix build error with Visual Studio 16.7.0 #12870
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LilyWangL
added
category:port-bug
The issue is with a library, which is something the port should already support
info:internal
This PR or Issue was filed by the vcpkg team.
labels
Aug 12, 2020
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
I don't know why there were the linux failures; it looks like an incorrectly declared dependency, but when I try myself the problem doesn't repro. Just going to try rerun...
|
Well now it passed ¯_(ツ)_/¯ |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Thanks for your contribution! I merged even though this was marked draft because it is blocking the infrastructure update to 16.7. |
@BillyONeal @LilyWangL Thank you, works like before. Have a great weekend. |
remz1337
pushed a commit
to remz1337/vcpkg
that referenced
this pull request
Aug 23, 2020
maflcko
pushed a commit
to bitcoin/bitcoin
that referenced
this pull request
Aug 31, 2020
a104cae Update the vcpkg checkout commit ID in appveyor config. (Aaron Clauson) Pull request description: A recent appveyor vm update broke the build of the `berkeleydb` vcpkg dependency, see #19839. The temporary resolution was to switch back to the previous appveyor vm. This PR updates the pegged vcpkg commit ID to the most recent commit as of 31 Aug 2020. That commit ID has been tested against the latest appveyor vm and is able to build Bitcoin Core successfully. The vcpkg bump includes a [patch](microsoft/vcpkg#12870) to the `berkeleydb` build config which allows it to be built on the latest appveyor vm. ACKs for top commit: MarcoFalke: Concept ACK a104cae Tree-SHA512: 6d363d1615c51bb3d4b324eb96d53950648fc97fc81ffaef91ee6e92f1336776d150d89f6e859f354ee75ce66afcef07aa19ed39b725dbb3f47ba67d26e111db
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
category:port-bug
The issue is with a library, which is something the port should already support
info:internal
This PR or Issue was filed by the vcpkg team.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
Due to
berkeleydb
defining a function-like macroatomic_init
of the same name as a standard library,berkeleydb
build failed with Visual Studio 16.7.0. Adding patch to rename macroatomic_init
, this will fix this issue temporarily.No
Yes