Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[proj4] use sqlite3 config cmake, make sqlite3 private #12875

Merged
merged 1 commit into from
Aug 14, 2020

Conversation

janholt
Copy link
Contributor

@janholt janholt commented Aug 12, 2020

Fixes #9225
In this PR
proj4 finds sqlite3 by find_package(unofficial-sqlite3 CONFIG), links it as PRIVATE library;
proj4-config.cmake for static proj4 has find_packge sqlite3.

@PhoebeHui PhoebeHui self-assigned this Aug 13, 2020
Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@PhoebeHui PhoebeHui added category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines labels Aug 14, 2020
@strega-nil strega-nil merged commit 04b0fe8 into microsoft:master Aug 14, 2020
remz1337 pushed a commit to remz1337/vcpkg that referenced this pull request Aug 23, 2020
@janholt janholt deleted the proj4_use_sqlite3_config branch September 22, 2020 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PROJ4] Target file links only release sqlite3
3 participants