Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libvorbis] Update to 1.3.7 #12909

Merged
merged 3 commits into from
Aug 20, 2020
Merged

Conversation

evpobr
Copy link
Contributor

@evpobr evpobr commented Aug 14, 2020

Update to official 1.3.7 release. No triplets/featues modified. CONTROL replaced with vcpkg.json.

@NancyLi1013 NancyLi1013 self-assigned this Aug 17, 2020
@NancyLi1013 NancyLi1013 added the category:port-update The issue is with a library, which is requesting update new revision label Aug 17, 2020
@NancyLi1013 NancyLi1013 added the info:reviewed Pull Request changes follow basic guidelines label Aug 17, 2020
# Conflicts:
#	ports/libvorbis/CONTROL
@NancyLi1013
Copy link
Contributor

The regression on arm64-windows was caused by soil:
It looks like the URL has been invalid now. I also checked the address http://www.lonesock.net , which cannot be available.

We might need to update the repository for soil. I searched several repos for soil on GitHub, but I'm not sure which one is the proper one.
https:/kbranigan/Simple-OpenGL-Image-Library this repo is cloned from the original website provided in vcpkg. There are still some new changes in this repo.

So could you help give some suggestions about this issue? @BillyONeal

Starting package 10/10: soil:arm64-windows
Building package soil[core]:arm64-windows...
Could not locate cached archive: W:\bd\bdcfcc29462abd2494b51c489a08f6c2ed7b8ad8.zip
-- Downloading http://www.lonesock.net/files/soil.zip...
-- Downloading http://www.lonesock.net/files/soil.zip... Failed. Status: 22;"HTTP response code said error"
CMake Error at scripts/cmake/vcpkg_download_distfile.cmake:176 (message):
      
      Failed to download file.
      If you use a proxy, please set the HTTPS_PROXY and HTTP_PROXY environment
      variables to "https://user:***@your-proxy-ip-address:port/".
      Otherwise, please submit an issue at https:/Microsoft/vcpkg/issues

Call Stack (most recent call first):
  ports/soil/portfile.cmake:3 (vcpkg_download_distfile)
  scripts/ports.cmake:79 (include)

@BillyONeal
Copy link
Member

@NancyLi1013 Nope, looks like upstream is just gone :/

@BillyONeal BillyONeal merged commit 89aa2f3 into microsoft:master Aug 20, 2020
@BillyONeal
Copy link
Member

Thanks for your contribution!

remz1337 pushed a commit to remz1337/vcpkg that referenced this pull request Aug 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants