Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[protobuf] protobuf v3.13.0 #12918

Merged
merged 2 commits into from
Aug 21, 2020
Merged

Conversation

jozefizso
Copy link
Contributor

Update to Protocol Buffers v3.13.0
https:/protocolbuffers/protobuf/releases/tag/v3.13.0

@NancyLi1013 NancyLi1013 added the category:port-update The issue is with a library, which is requesting update new revision label Aug 17, 2020
Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

ports/protobuf/CONTROL Outdated Show resolved Hide resolved
@PhoebeHui PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label Aug 20, 2020
@BillyONeal
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@BillyONeal
Copy link
Member

The arm-uwp failures look legitimate...

@jozefizso
Copy link
Contributor Author

The build arm_uwp failed because of:

-- Downloading https:/protocolbuffers/protobuf/archive/fde7cf7358ec7cd69e8db9be4f1fa6a5c431386a.tar.gz...
-- Extracting source D:/downloads/protocolbuffers-protobuf-fde7cf7358ec7cd69e8db9be4f1fa6a5c431386a.tar.gz
-- Applying patch fix-uwp.patch
-- Applying patch fix-android-log.patch
-- Applying patch fix-static-build.patch
-- Using source at D:/buildtrees/protobuf/src/a5c431386a-c9deea9e31.clean
CMake Error at ports/protobuf/portfile.cmake:22 (message):
  Cross-targetting protobuf requires the x86-windows protoc to be available.
  Please install protobuf:x86-windows first.
Call Stack (most recent call first):
  scripts/ports.cmake:79 (include)

I'm not sure what to do here. When I build the protoc:x86-windows first and protoc:arm_uwp second, it works.

@BillyONeal
Copy link
Member

BillyONeal commented Aug 21, 2020

I'm not sure what to do here. When I build the protoc:x86-windows first and protoc:arm_uwp second, it works.

CI currently installs "protobuf:x86-windows" first to make this work:

# WORKAROUND: the x86-windows flavors of these are needed for all cross-compilation, but they are not auto-installed.
# Install them so the CI succeeds:
if ($Triplet -in @('x64-uwp', 'arm64-windows', 'arm-uwp')) {
.\vcpkg.exe install protobuf:x86-windows boost-build:x86-windows sqlite3:x86-windows @commonArgs
}

Perhaps that was split into "protoc" instead and that wasn't updated?

@PhoebeHui
Copy link
Contributor

It pass after rerun, and I noticed that protobuf:x86-windows installed successfully, and protobuf:arm_uwp as well.

@BillyONeal
Copy link
Member

It pass after rerun, and I noticed that protobuf:x86-windows installed successfully, and protobuf:arm_uwp as well.

Oh great, flaky ports :(. Oh well I guess.

@jozefizso Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants