Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ffmpeg] fix cmake module #13004

Merged
merged 6 commits into from
Aug 21, 2020
Merged

[ffmpeg] fix cmake module #13004

merged 6 commits into from
Aug 21, 2020

Conversation

cenit
Copy link
Contributor

@cenit cenit commented Aug 19, 2020

Fixes #12993

@NancyLi1013
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JackBoosY JackBoosY added category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines labels Aug 20, 2020
Sibras
Sibras reviewed Aug 20, 2020
View reviewed changes
Copy link
Contributor

@Sibras Sibras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything else looks fine apart from the 2 issues noted

ports/ffmpeg/FindFFMPEG.cmake.in Outdated Show resolved Hide resolved
ports/ffmpeg/FindFFMPEG.cmake.in Outdated Show resolved Hide resolved
@cenit cenit mentioned this pull request Aug 20, 2020
Closed
@cenit
Copy link
Contributor Author

cenit commented Aug 20, 2020

@Sibras do you like it more now?

@Sibras
Copy link
Contributor

Sibras commented Aug 20, 2020

lgtm

@BillyONeal BillyONeal merged commit 0ccb9d3 into microsoft:master Aug 21, 2020
@BillyONeal
Copy link
Member

Thanks for your contribution!

remz1337 pushed a commit to remz1337/vcpkg that referenced this pull request Aug 23, 2020
@cenit @remz1337
[ffmpeg] fix cmake module (microsoft#13004)
df144ca
@cenit cenit deleted the dev/cenit/ffmpeg branch August 24, 2020 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sibras Sibras Sibras left review comments

@JackBoosY JackBoosY JackBoosY approved these changes

Assignees

@JackBoosY JackBoosY

Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[opencv4] Building package opencv4:x64-windows failed
5 participants
@cenit @NancyLi1013 @Sibras @BillyONeal @JackBoosY