Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pcl] check SSE flags #13020

Merged
merged 2 commits into from
Aug 21, 2020
Merged

[pcl] check SSE flags #13020

merged 2 commits into from
Aug 21, 2020

Conversation

JackBoosY
Copy link
Contributor

vcpkg add extra cxx flag -fpic, so pcl didn't check sse flags.

Fixes #11137.

@JackBoosY JackBoosY added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Aug 20, 2020
@PhoebeHui PhoebeHui changed the title [pcl] Always check SSE flags [pcl] check SSE flags Aug 21, 2020
@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Aug 21, 2020
@BillyONeal BillyONeal merged commit 5a240bc into microsoft:master Aug 21, 2020
@BillyONeal
Copy link
Member

Thanks for your contribution!

remz1337 pushed a commit to remz1337/vcpkg that referenced this pull request Aug 23, 2020
@JackBoosY @remz1337
[pcl] check SSE flags (microsoft#13020)
cfb37d3 
* [pcl] Always check SSE flags

* check sse if sse enabled
@JackBoosY JackBoosY deleted the dev/jack/11137 branch August 24, 2020 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhoebeHui PhoebeHui PhoebeHui approved these changes

Assignees

@PhoebeHui PhoebeHui

Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[pcl] Enable SSE -march=native flag
3 participants
@JackBoosY @BillyONeal @PhoebeHui