Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[date] Update to 2019-11-08 #9006

Merged
merged 1 commit into from
Nov 22, 2019
Merged

Conversation

qis
Copy link
Contributor

@qis qis commented Nov 14, 2019

This updates the date port to the latest version.

The HowardHinnant/date@a5c4b4e commit is necessary to use (not just build and install) the library in combination with a recent libc++. The later changes are not necessary, but nice to have.

Portfile changes:

  • The ENABLE_DATE_TESTING option is off by default now, so there is no need to set it explicitly.
  • The BUILD_TZ_LIB option is off by default now, so it has to be set explicitly.

@qis
Copy link
Contributor Author

qis commented Nov 18, 2019

While you review it, the new CMakeLists.txt switched to C++17 by default, so it might actually close #4864.

@grdowns grdowns self-assigned this Nov 18, 2019
@JackBoosY
Copy link
Contributor

/azp run

@grdowns grdowns changed the title [date] update to latest version [date] Update to latest version Nov 19, 2019
@grdowns grdowns changed the title [date] Update to latest version [date] Update to 2019-11-08 Nov 19, 2019
@LilyWangL
Copy link
Contributor

Hi @qis, thanks for your new PR. Here are some regressions from the current CI system:

x64-osx master test notes
date Pass Fail Regression
x86-windows master test notes
date Pass Fail Regression
x64-uwp master test notes
date Pass Fail Regression
arm-uwp master test notes
date Pass Fail Regression

[date] added cmake 3.14 backwards compatibility patch
@qis
Copy link
Contributor Author

qis commented Nov 21, 2019

@LilyWangL Ah yes. Glad to get useful logs out of your CI now. Congratulations on fixing it!

I've added a backwards compatibility patch for CMake 3.14. It should be removed when vcpkg moves to 3.15 or later.

Will test future PRs with outdated CMake versions.

Where can I find the lowest officially supported version? Is it os=windows, os=osx, and os=linux in scripts/vcpkgTools.xml or should I also respect the even more outdated version for os=freebsd?

@ras0219-msft
Copy link
Contributor

You can ignore the os=freebsd; the lowest officially supported version is os=windows, os=osx, and os=linux.

@ras0219-msft ras0219-msft merged commit 2846c89 into microsoft:master Nov 22, 2019
@ras0219-msft
Copy link
Contributor

LGTM, thanks!

@qis qis deleted the dev/qis/date branch November 22, 2019 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants