[boost-modular-build-helper] Fix issue that link incorrect dependent libraries #9224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
JackBoosY
approved these changes
Dec 16, 2019
JackBoosY
changed the title
|
/azp run |
|
Related to #9780 |
|
Please resolve conflicts. Thanks. |
|
Hi there, I rebased @PhoebeHui's branch on the latest master and tested successfully on Linux and macOS: https:/jgiannuzzi/vcpkg/tree/boost-modular-build-helper. @PhoebeHui could you please update this PR? Otherwise I can create a separate PR, whichever is easier for you! |
|
@jgiannuzzi Feel free to open a new PR, thanks. |
PhoebeHui
added
the
category:port-bug
|
@ras0219-msft, could you help review this PR? |
ras0219
approved these changes
Aug 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue #7559 and #8613
In current Jamroot.jam, it configured both release and debug libraries, but doesn’t distinguish them, when build release libraries, it try to find dependency port debug libraries, that cause build failures.
To fix this issue, configured the Jamroot.jam before build release libraries, and configured it with debug build info again when build debug libraries.
boost-modular-build-helper has no features that need to test locally.