Ensure updates to openFileVersion data is not delayed
#12851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have been occasionally seeing stale colorization get applied, immediately after making an edit. I've repro'ed it with a complex TU, which takes some time to update, and noticed that it occurs quickly, as if stale results are being applied after an edit. I haven't been able to find any issues with document version tracking in the native code. I thought perhaps I could be seeing the result of: microsoft/vscode#74094
What I think is going on here is that due to
onDidChangeTextDocumentbeing delivered from the protocolFilter, it's being delayed until any other messages in queue have been processed. Since we're considering theopenFileVersionto be the authority on the 'current' state of open files, this delay seems like a bad thing.This change moves delivery of
onDidChangeTextDocumentinto an event handler, which should avoid the delay.