Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UnixProcessProvider Failed to Find Dapr Process CMD on Mac #169

Closed
jasonviviano opened this issue May 24, 2021 · 0 comments
Closed

UnixProcessProvider Failed to Find Dapr Process CMD on Mac #169

jasonviviano opened this issue May 24, 2021 · 0 comments
Labels
bug Something isn't working
Milestone
0.5.0

Comments

@jasonviviano
Copy link
Contributor

Description
The current implementation for finding Dapr processes uses the library ps-list, the usage can be found here:

vscode-dapr/src/services/processProvider.ts

Line 23 in 665dabf

.filter(process => process.name === name)

There's a method for Windows and Mac, however on Mac there's been a bug were the current Dapr applications have trouble being found. It seems that the current processes cmd name matching relied on 'daprd' but simply changing the name to 'dapr' as the matching string allowed for dapr cli initiated apps to be found.

** Tests **
Tested locally with running the following Dapr apps,

dapr run --app-id pppptest --app-port 3560 --dapr-http-port 3850 node app.js
dapr run --app-id nodeapptesttt --app-port 3550 --dapr-http-port 3800 node app.js
@jasonviviano jasonviviano mentioned this issue May 24, 2021
Closed
@sk593 sk593 mentioned this issue Jun 9, 2021
Merged
@philliphoff philliphoff mentioned this issue Jun 16, 2021
Closed
@philliphoff philliphoff added this to the 0.5.0 milestone Jun 16, 2021
sk593 added a commit to sk593/vscode-dapr that referenced this issue Jun 18, 2021
@sk593
Merge branch 'microsoft:main' into daprdProcBug-microsoft#169
d589e0f
@sk593 sk593 mentioned this issue Jun 18, 2021
Merged
sk593 added a commit to sk593/vscode-dapr that referenced this issue Jul 1, 2021
@sk593
Merge branch 'main' into daprdProcBug-microsoft#169
1cfa4ab
sk593 added a commit to sk593/vscode-dapr that referenced this issue Jul 6, 2021
@sk593
Merge branch 'daprdProcBug-microsoft#169' of github.com:sk593/vscode-…
0a5cb45 
…dapr into daprdProcBug-microsoft#169

merging main into branch
sk593 added a commit to sk593/vscode-dapr that referenced this issue Jul 13, 2021
@sk593
Merge branch 'main' of github.com:sk593/vscode-dapr into daprdProcBug-m…
25d21a1 
…icrosoft#169
sk593 added a commit that referenced this issue Jul 15, 2021
@sk593
Bug fix for daprd proc bug #169 (#185)
8a607ad 
* updated process finder to get all daprd instances

* removed added functions from app provider

* updated processProvider to look for all forms of daprd (daprd and ~/daprd)

* removed unneeded code from daprAppProvider

* updated to use which module to find daprd executables

* expanded mac proc finder logic

* updating package-lock

* added open telemetry module

* minor changes to process provider logic

* minor refactoring/changes
@sk593 sk593 closed this as completed Jul 15, 2021
@philliphoff philliphoff added the bug Something isn't working label Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
0.5.0
Development

No branches or pull requests
3 participants
@philliphoff @sk593 @jasonviviano