Set which encoding your test JVM will start with #1735
Conversation
This patch adds a setting to the `java.test.config` object.
```jsonc
{
"java.test.config": {
"encoding": "ISO-8859-1",
},
}
```
The aim here is to be able to seamlessly test code which cares
about the launch encoding of the JVM. Yes, such code is not good.
But sometimes you don't control your dependencies enough to fix
this.
Since the debug launcher already cares about the `encoding` member of the
config, the only thing required is to add the member, which is missing
from the launch configs generated by the test plugin.
```typescript
// In `configurationProvider.ts:` (vscode-java-debug)
// VS Code internal console uses UTF-8 to display output by default.
if (config.console === "internalConsole" && !config.encoding) {
config.encoding = "UTF-8";
}
```
Fixes microsoft#1641
|
PS : had to change the update site for eclipse to <repository location="https://download.eclipse.org/eclipse/updates/4.33/R-4.33-202409030240/"/>: the older URL doesn't seem available any more. I'm presuming your builds are behind a Maven repo that has this stuff cached, but building the source as-is from publicly available builds isn't currently possible. I've not submitted this as part of the PR (because I figure you have that Maven repo), but I'm mentioning it so you know. |
Updated the target platform definition in #1734 |
|
Hi @awilkins, Sorry that I'm just back from vacation and I will review this ASAP. |
| @@ -254,6 +254,11 @@ | |||
| "markdownDescription": "%configuration.java.test.config.javaExec.description%", | |||
| "default": "" | |||
| }, | |||
| "encoding": { | |||
There was a problem hiding this comment.
Since java.test.config can either be an array or an object. So we need to duplicated this under item section as well. (start from line 349)
There was a problem hiding this comment.
Also noted, because they're right next to each other, that it's vmargs in the array and vmArgs in the singular ; have changed the case of the array to match (this has been deprecated 4 years, I think it might have been long enough :-) )
This patch adds a setting to the
java.test.configobject.The aim here is to be able to seamlessly test code which cares about the launch encoding of the JVM. Yes, such code is not good. But sometimes you don't control your dependencies enough to fix this.
Since the debug launcher already cares about the
encodingmember of the config, the only thing required is to add the member, which is missing from the launch configs generated by the test plugin.Fixes #1641
NB : I couldn't work out how to actually launch and gather results from Java tests, in the Typescript test suite, but I did add a Java test case that cares about the launch encoding and tested it manually.