-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Map paths for console.error(...) #412
Comments
Good idea, should be fairly easy |
This might slip to June. The stacks of logged errors isn't easy to pluck out--we need to actually do some string parsing. This introduces some complexity, and at the moment the console message handling we do is very simple and imperative. I'd like to clean up and extract some of this logic rather than tacking it onto what we have today. |
Thanks for the update! I appreciate it. |
I think this isn't working for me. Just added |
It looks like the first line of the stack isn't in parens, so our regex doesn't match it. It should match the 3rd line, but that looks like it's in a TS header that won't have a source map location. |
Unclear how to verify. |
Original discussion in the 'vscode-chrome-debug-core' repo here: microsoft/vscode-chrome-debug-core#553
Long story short, I would like to request a feature in which console.error() messages are also processed to map paths back to source files. This would be helpful for angular developers where the main typescript file that bootstraps the app is setup to catch any errors and use console.erorr() to display them in the console. Please let me know if you need more info!
The text was updated successfully, but these errors were encountered: