Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debug.javascript.autoAttachFilter: "always" does not work #733

Closed
isidorn opened this issue Sep 1, 2020 · 4 comments
Closed

debug.javascript.autoAttachFilter: "always" does not work #733

isidorn opened this issue Sep 1, 2020 · 4 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@isidorn
Copy link

isidorn commented Sep 1, 2020

Refs: microsoft/vscode#105771

Have the following settings in your settings.json

"debug.node.autoAttach": "on",
"debug.javascript.usePreviewAutoAttach": true,
"debug.javascript.autoAttachFilter": "always"
  1. Open our Smoke test express app
  2. Open the integreted terminal
  3. node bin/www does not get auto attached 🐛

If I do node --inspect bin/www it auto attaches nicely.
This is not expected since I explicitly set "debug.javascript.autoAttachFilter": "always"

@isidorn isidorn added the bug Issue identified by VS Code Team member as probable bug label Sep 1, 2020
@connor4312
Copy link
Member

Note that if you changed the setting outside the workspace, you have to toggle auto attach to disabled then enabled for it to take effect (I need to fix this.) Does this sound like what you hit?

@connor4312
Copy link
Member

Closing as a tentative dupe of #731. Please let me know if you see this on the next Insiders.

@connor4312 connor4312 added this to the August 2020 milestone Sep 1, 2020
@isidorn
Copy link
Author

isidorn commented Sep 1, 2020

I probably hit this. I will verify this tomorrow.

@isidorn isidorn added the verified Verification succeeded label Sep 3, 2020
@isidorn
Copy link
Author

isidorn commented Sep 3, 2020

Works fine now, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

2 participants