fix: better handling of multiple/relative outFiles #1486
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1479
Relates to microsoft/vscode#168635
Previously, we naively joined all incoming globs together and ran a
single search for them. However, there are two problems:
!**/node_modules/**
, should applyeverywhere, but globbing behavior is to only apply that to the base
path, which led to confusion (Apply glob negations if glob is navigated outside workspace folder #1479)
This PR redoes the logic. If there are N positive globs, we'll do N
searches in parallel, and apply relevant negations to each one.